Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753327AbcCWUHr (ORCPT ); Wed, 23 Mar 2016 16:07:47 -0400 Received: from smtp.codeaurora.org ([198.145.29.96]:44824 "EHLO smtp.codeaurora.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751350AbcCWUHp (ORCPT ); Wed, 23 Mar 2016 16:07:45 -0400 Subject: Re: [PATCH 04/12] ARM: dts: dragonboard-600c: add board support with serial To: Srinivas Kandagatla , Andy Gross , linux-arm-msm@vger.kernel.org References: <1458762366-9233-1-git-send-email-srinivas.kandagatla@linaro.org> <1458762442-9492-1-git-send-email-srinivas.kandagatla@linaro.org> Cc: devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-soc@vger.kernel.org From: Stephen Boyd Message-ID: <56F2F78E.8050002@codeaurora.org> Date: Wed, 23 Mar 2016 13:07:42 -0700 User-Agent: Mozilla/5.0 (X11; Linux i686 on x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.6.0 MIME-Version: 1.0 In-Reply-To: <1458762442-9492-1-git-send-email-srinivas.kandagatla@linaro.org> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 835 Lines: 21 On 03/23/2016 12:47 PM, Srinivas Kandagatla wrote: > diff --git a/arch/arm/boot/dts/qcom-apq8064-dragonboard-600c.dts b/arch/arm/boot/dts/qcom-apq8064-dragonboard-600c.dts > new file mode 100644 > index 0000000..e96aab6 > --- /dev/null > +++ b/arch/arm/boot/dts/qcom-apq8064-dragonboard-600c.dts > @@ -0,0 +1,36 @@ > +#include "qcom-apq8064-v2.0.dtsi" > + > +/ { > + model = "Qualcomm Technologies, Inc. APQ8064 DragonBoard600c"; > + compatible = "qcom,apq8064-dragonboard600c", "qcom,apq8064"; Does the bootloader look at this string at all or is it using appended DTB design? I'm mostly worried about having that qcom,apq8064-dragonboard600c part. It should probably be qcom,apq8064-sbc or something like that instead. -- Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, a Linux Foundation Collaborative Project