Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756651AbcCWUZd (ORCPT ); Wed, 23 Mar 2016 16:25:33 -0400 Received: from bh-25.webhostbox.net ([208.91.199.152]:56509 "EHLO bh-25.webhostbox.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752404AbcCWUZc (ORCPT ); Wed, 23 Mar 2016 16:25:32 -0400 Date: Wed, 23 Mar 2016 13:25:21 -0700 From: Guenter Roeck To: Xuetao Guan Cc: linux-kernel@vger.kernel.org, Dave Hansen , Thomas Gleixner , Ingo Molnar Subject: Re: [PATCH] unicore32: mm: Add missing parameter to arch_vma_access_permitted Message-ID: <20160323202521.GA31744@roeck-us.net> References: <1458559253-422-1-git-send-email-linux@roeck-us.net> <63436.117.114.135.40.1458560849.squirrel@mprc.pku.edu.cn> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <63436.117.114.135.40.1458560849.squirrel@mprc.pku.edu.cn> User-Agent: Mutt/1.5.23 (2014-03-12) X-Authenticated_sender: guenter@roeck-us.net X-OutGoing-Spam-Status: No, score=-1.0 X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - bh-25.webhostbox.net X-AntiAbuse: Original Domain - vger.kernel.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - roeck-us.net X-Get-Message-Sender-Via: bh-25.webhostbox.net: authenticated_id: guenter@roeck-us.net X-Authenticated-Sender: bh-25.webhostbox.net: guenter@roeck-us.net X-Source: X-Source-Args: X-Source-Dir: Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1731 Lines: 51 On Mon, Mar 21, 2016 at 07:47:29PM +0800, Xuetao Guan wrote: > > unicore32 fails to compile with the following errors. > > > > mm/memory.c: In function 鈥榑_handle_mm_fault鈥�: > > mm/memory.c:3381: error: > > too many arguments to function 鈥榓rch_vma_access_permitted鈥� > > mm/gup.c: In function 鈥榗heck_vma_flags鈥�: > > mm/gup.c:456: error: > > too many arguments to function 鈥榓rch_vma_access_permitted鈥� > > mm/gup.c: In function 鈥榲ma_permits_fault鈥�: > > mm/gup.c:640: error: > > too many arguments to function 鈥榓rch_vma_access_permitted鈥� > > > > Fixes: d61172b4b695b ("mm/core, x86/mm/pkeys: Differentiate instruction > > fetches") > > Cc: Dave Hansen > > Cc: Thomas Gleixner > > Cc: Ingo Molnar > > Signed-off-by: Guenter Roeck > > Thanks. > > Acked-by: Guan Xuetao > Who is going to send the patch upstream ? Guenter > > --- > > arch/unicore32/include/asm/mmu_context.h | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/arch/unicore32/include/asm/mmu_context.h > > b/arch/unicore32/include/asm/mmu_context.h > > index e35632ef23c7..62dfc644c908 100644 > > --- a/arch/unicore32/include/asm/mmu_context.h > > +++ b/arch/unicore32/include/asm/mmu_context.h > > @@ -98,7 +98,7 @@ static inline void arch_bprm_mm_init(struct mm_struct > > *mm, > > } > > > > static inline bool arch_vma_access_permitted(struct vm_area_struct *vma, > > - bool write, bool foreign) > > + bool write, bool execute, bool foreign) > > { > > /* by default, allow everything */ > > return true; > > -- > > 2.5.0 > > >