Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755519AbcCWUaP (ORCPT ); Wed, 23 Mar 2016 16:30:15 -0400 Received: from mail-wm0-f53.google.com ([74.125.82.53]:35311 "EHLO mail-wm0-f53.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753535AbcCWUaL (ORCPT ); Wed, 23 Mar 2016 16:30:11 -0400 Subject: Re: [PATCH 04/12] ARM: dts: dragonboard-600c: add board support with serial To: Stephen Boyd , Andy Gross , linux-arm-msm@vger.kernel.org References: <1458762366-9233-1-git-send-email-srinivas.kandagatla@linaro.org> <1458762442-9492-1-git-send-email-srinivas.kandagatla@linaro.org> <56F2F78E.8050002@codeaurora.org> Cc: devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-soc@vger.kernel.org From: Srinivas Kandagatla Message-ID: <56F2FCD0.1000708@linaro.org> Date: Wed, 23 Mar 2016 20:30:08 +0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.6.0 MIME-Version: 1.0 In-Reply-To: <56F2F78E.8050002@codeaurora.org> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 948 Lines: 28 On 23/03/16 20:07, Stephen Boyd wrote: > On 03/23/2016 12:47 PM, Srinivas Kandagatla wrote: >> diff --git a/arch/arm/boot/dts/qcom-apq8064-dragonboard-600c.dts b/arch/arm/boot/dts/qcom-apq8064-dragonboard-600c.dts >> new file mode 100644 >> index 0000000..e96aab6 >> --- /dev/null >> +++ b/arch/arm/boot/dts/qcom-apq8064-dragonboard-600c.dts >> @@ -0,0 +1,36 @@ >> +#include "qcom-apq8064-v2.0.dtsi" >> + >> +/ { >> + model = "Qualcomm Technologies, Inc. APQ8064 DragonBoard600c"; >> + compatible = "qcom,apq8064-dragonboard600c", "qcom,apq8064"; > > Does the bootloader look at this string at all or is it using appended > DTB design? I'm mostly worried about having that Not at least on APQ8064 bootloaders, as they are still missing DT support. Currently we append dtb to the kernel. > qcom,apq8064-dragonboard600c part. It should probably be > qcom,apq8064-sbc or something like that instead. Will do that in next version. thanks, srini >