Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932292AbcCWUnm (ORCPT ); Wed, 23 Mar 2016 16:43:42 -0400 Received: from mail.linuxfoundation.org ([140.211.169.12]:34821 "EHLO mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756637AbcCWUnl (ORCPT ); Wed, 23 Mar 2016 16:43:41 -0400 Date: Wed, 23 Mar 2016 16:43:39 -0400 From: "'Greg Kroah-Hartman'" To: "Simmons, James A." Cc: "'Joe Perches'" , "Dilger, Andreas" , "devel@driverdev.osuosl.org" , "Drokin, Oleg" , Linux Kernel Mailing List , Lustre Development List Subject: Re: [lustre-devel] [PATCH] Revert "Staging: lustre: o2iblnd: Use sizeof type *pointer instead of sizeof type." Message-ID: <20160323204339.GA21923@kroah.com> References: <1458685264-22755-1-git-send-email-jsimmons@infradead.org> <20160323014916.GF3190@kroah.com> <20160323134107.GA4356@kroah.com> <1458758864.18165.4.camel@perches.com> <7dcad179d49c4535b4f24d3ceb85607a@EXCHCS32.ornl.gov> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <7dcad179d49c4535b4f24d3ceb85607a@EXCHCS32.ornl.gov> User-Agent: Mutt/1.5.24 (2015-08-30) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 820 Lines: 24 On Wed, Mar 23, 2016 at 08:29:49PM +0000, Simmons, James A. wrote: > > >> > > so the right code should be: > >> > > > >> > > ????????sizeof(**net->ibn_tx_ps); > >> > > and the same for sizeof(**net->ibn_fmr_ps) > >> > That's a mess, isn't there some other way to fix this up to be more > >> > "obvious"? > >> This must have been encountered in the past. How was it handle in those > >> other cases? > > > >I fail to see why it's a mess. It's just ** > >and someone making a mistake. > > I have no trouble with **. If we revert it someone else will come along and > do the same mistake so I think we are stuck with the change to **. That's fine, but if you do that, just comment it well so that no one tries to change it again. That's why I can't accept the original patch in this email thread. thanks, greg k-h