Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754275AbcCXA33 (ORCPT ); Wed, 23 Mar 2016 20:29:29 -0400 Received: from lists.s-osg.org ([54.187.51.154]:56788 "EHLO lists.s-osg.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751556AbcCXA32 (ORCPT ); Wed, 23 Mar 2016 20:29:28 -0400 Subject: Re: [RFC PATCH] ARM: exynos_defconfig: Enable Samsung media platform drivers as modules To: Krzysztof Kozlowski , linux-kernel@vger.kernel.org References: <1458745109-21036-1-git-send-email-javier@osg.samsung.com> <56F32AFF.60102@samsung.com> Cc: linux-samsung-soc@vger.kernel.org, Kukjin Kim From: Javier Martinez Canillas Message-ID: <56F334DF.4050805@osg.samsung.com> Date: Wed, 23 Mar 2016 21:29:19 -0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.6.0 MIME-Version: 1.0 In-Reply-To: <56F32AFF.60102@samsung.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1497 Lines: 42 Hello Krzysztof, On 03/23/2016 08:47 PM, Krzysztof Kozlowski wrote: > On 23.03.2016 23:58, Javier Martinez Canillas wrote: >> There are a bunch of media platform drivers under drivers/media/platform/ >> that are for Samsung SoCs but are not being built with exynos_defconfig. >> >> This patch enables them as a module to improve build coverage for these >> drivers and also to allow people use them with proper hardware if modules >> are installed. The S5P MFC driver wasn't enabled since it fails to probe. >> >> Only the boolean Kconfig symbols are enabled as built-in, since drivers >> are not critical and also to keep the kernel binary image size as small >> as possible. >> >> Signed-off-by: Javier Martinez Canillas >> >> --- >> Hello Kukjin and Krzysztof, >> >> I'm posting this as a RFC because I don't know if it will add too much bloat >> to a kernel built with exynos_defconfig. >> >> I think it doesn't since the image size only increased 15 KiB which seems to >> be a small price for having these built, but you may have another opinion. > > I like enabling as modules whatever look necessary or useful. I don't > see problems if it requires turning other things to built-in. Please go > ahead with the patch (and follow up after Tobias comments). > Thanks a lot for your feedback. I went and posted a v2 then addressing Tobias comments. > Best regards, > Krzysztof Best regards, -- Javier Martinez Canillas Open Source Group Samsung Research America