Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932127AbcCXB3G (ORCPT ); Wed, 23 Mar 2016 21:29:06 -0400 Received: from mail-lb0-f193.google.com ([209.85.217.193]:34542 "EHLO mail-lb0-f193.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752955AbcCXB3B (ORCPT ); Wed, 23 Mar 2016 21:29:01 -0400 MIME-Version: 1.0 In-Reply-To: <1458764521.27934.168.camel@linux.intel.com> References: <1458706064-4147-1-git-send-email-srinivas.pandruvada@linux.intel.com> <56F2C7B5.4000208@hpe.com> <1458764521.27934.168.camel@linux.intel.com> Date: Thu, 24 Mar 2016 02:28:59 +0100 X-Google-Sender-Auth: haRaHzqETTPImCNztbZqNJponxs Message-ID: Subject: Re: [PATCH v6] acpi: Issue _OSC call for native thermal interrupt handling From: "Rafael J. Wysocki" To: Srinivas Pandruvada Cc: Linda Knippers , "Rafael J. Wysocki" , Tony Luck , Borislav Petkov , Thomas Gleixner , Ingo Molnar , "H. Peter Anvin" , Len Brown , "open list:EDAC-CORE" , Linux Kernel Mailing List , ACPI Devel Maling List Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1167 Lines: 35 On Wed, Mar 23, 2016 at 9:22 PM, Srinivas Pandruvada wrote: > On Wed, 2016-03-23 at 12:43 -0400, Linda Knippers wrote: >> I raised a general concern on a previous patch so I found a 1P server >> with Skylake and HWP to try. This doesn't qualify as a tested-by >> since all I did was apply the patch and boot the server but hey, it >> booted. > Thanks. > >> >> I do have a question below... >> > [...] >> + if (ACPI_SUCCESS(acpi_run_osc(handle, &osc_context))) { >> > + acpi_hwp_native_thermal_lvt_set = true; >> > + kfree(osc_context.ret.pointer); >> >> There are other boot messages that indicate when something is >> happening >> with _OSC. Should there be one for this? Or is there some other >> obvious >> way one can know that this was set? >> > I am following model of acpi_bus_osc_support, which issues _OSC for > global platform scope, where nothing is getting printed. If it is > useful, I don't mind adding a print. > > Rafael, > What do you think? Printing a message after acpi_run_osc() has been called successfully shouldn't hurt. Maybe using acpi_handle_info()? Thanks, Rafael