Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932211AbcCXFNM (ORCPT ); Thu, 24 Mar 2016 01:13:12 -0400 Received: from mx0a-0016f401.pphosted.com ([67.231.148.174]:31039 "EHLO mx0a-0016f401.pphosted.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751104AbcCXFNI (ORCPT ); Thu, 24 Mar 2016 01:13:08 -0400 From: Jisheng Zhang To: , , , CC: , , Jisheng Zhang Subject: [PATCH 1/2] arm64: cpuidle: remove cpu_ops check from arm_cpuidle_suspend() Date: Thu, 24 Mar 2016 13:08:49 +0800 Message-ID: <1458796130-6109-2-git-send-email-jszhang@marvell.com> X-Mailer: git-send-email 2.8.0.rc3 In-Reply-To: <1458796130-6109-1-git-send-email-jszhang@marvell.com> References: <1458796130-6109-1-git-send-email-jszhang@marvell.com> MIME-Version: 1.0 Content-Type: text/plain X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10432:,, definitions=2016-03-24_02:,, signatures=0 X-Proofpoint-Details: rule=outbound_notspam policy=outbound score=0 spamscore=0 suspectscore=0 malwarescore=0 phishscore=0 adultscore=0 bulkscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1601100000 definitions=main-1603240079 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 950 Lines: 28 If cpu_ops has not been registered, arm_cpuidle_init() will return -EOPNOTSUPP, so arm_cpuidle_suspend() will never have chance to run. In other word, the cpu_ops check can be avoid. Signed-off-by: Jisheng Zhang --- arch/arm64/kernel/cpuidle.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/arch/arm64/kernel/cpuidle.c b/arch/arm64/kernel/cpuidle.c index 9047cab6..bd57c59 100644 --- a/arch/arm64/kernel/cpuidle.c +++ b/arch/arm64/kernel/cpuidle.c @@ -37,10 +37,9 @@ int arm_cpuidle_suspend(int index) int cpu = smp_processor_id(); /* - * If cpu_ops have not been registered or suspend - * has not been initialized, cpu_suspend call fails early. + * If suspend has not been initialized, cpu_suspend call fails early. */ - if (!cpu_ops[cpu] || !cpu_ops[cpu]->cpu_suspend) + if (!cpu_ops[cpu]->cpu_suspend) return -EOPNOTSUPP; return cpu_ops[cpu]->cpu_suspend(index); } -- 2.8.0.rc3