Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754977AbcCXFPW (ORCPT ); Thu, 24 Mar 2016 01:15:22 -0400 Received: from mx0b-0016f401.pphosted.com ([67.231.156.173]:12378 "EHLO mx0b-0016f401.pphosted.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751116AbcCXFPU (ORCPT ); Thu, 24 Mar 2016 01:15:20 -0400 From: Jisheng Zhang To: , CC: , , Jisheng Zhang Subject: [PATCH 2/2] ARM: cpuidle: make arm_cpuidle_suspend() a bit more efficient Date: Thu, 24 Mar 2016 13:11:09 +0800 Message-ID: <1458796269-6158-3-git-send-email-jszhang@marvell.com> X-Mailer: git-send-email 2.8.0.rc3 In-Reply-To: <1458796269-6158-1-git-send-email-jszhang@marvell.com> References: <1458796269-6158-1-git-send-email-jszhang@marvell.com> MIME-Version: 1.0 Content-Type: text/plain X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10432:,, definitions=2016-03-24_02:,, signatures=0 X-Proofpoint-Details: rule=outbound_notspam policy=outbound score=0 spamscore=0 suspectscore=0 malwarescore=0 phishscore=0 adultscore=0 bulkscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1601100000 definitions=main-1603240079 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1150 Lines: 40 Currently, we check cpuidle_ops.suspend every time when entering a low-power idle state. But this check could be avoided in this hot path by moving it into arm_cpuidle_init() to reduce arm_cpuidle_suspend() overhead a bit. Signed-off-by: Jisheng Zhang --- arch/arm/kernel/cpuidle.c | 8 ++------ 1 file changed, 2 insertions(+), 6 deletions(-) diff --git a/arch/arm/kernel/cpuidle.c b/arch/arm/kernel/cpuidle.c index f108d8f..bf68d49 100644 --- a/arch/arm/kernel/cpuidle.c +++ b/arch/arm/kernel/cpuidle.c @@ -52,13 +52,9 @@ int arm_cpuidle_simple_enter(struct cpuidle_device *dev, */ int arm_cpuidle_suspend(int index) { - int ret = -EOPNOTSUPP; int cpu = smp_processor_id(); - if (cpuidle_ops[cpu].suspend) - ret = cpuidle_ops[cpu].suspend(index); - - return ret; + return cpuidle_ops[cpu].suspend(index); } /** @@ -144,7 +140,7 @@ int __init arm_cpuidle_init(int cpu) ret = arm_cpuidle_read_ops(cpu_node, cpu); if (!ret) { - if (cpuidle_ops[cpu].init) + if (cpuidle_ops[cpu].init && cpuidle_ops[cpu].suspend) ret = cpuidle_ops[cpu].init(cpu_node, cpu); else ret = -EOPNOTSUPP; -- 2.8.0.rc3