Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752592AbcCXGfx (ORCPT ); Thu, 24 Mar 2016 02:35:53 -0400 Received: from mga09.intel.com ([134.134.136.24]:1252 "EHLO mga09.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751005AbcCXGfp (ORCPT ); Thu, 24 Mar 2016 02:35:45 -0400 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.24,383,1455004800"; d="scan'208";a="943956526" From: "Brown, Len" To: "Zheng, Lv" , Joe Perches , "Wysocki, Rafael J" , "Rafael J. Wysocki" CC: Lv Zheng , "linux-kernel@vger.kernel.org" , "linux-acpi@vger.kernel.org" Subject: RE: [PATCH 01/30] ACPICA: Linuxize: reduce divergences for 20160212 release Thread-Topic: [PATCH 01/30] ACPICA: Linuxize: reduce divergences for 20160212 release Thread-Index: AQHRhW3ifqC+w3jTkUiTc6MkFyioMp9oSFkAgABMZ4D//44AgA== Date: Thu, 24 Mar 2016 06:35:44 +0000 Message-ID: <1A7043D5F58CCB44A599DFD55ED4C94846A17FF0@fmsmsx115.amr.corp.intel.com> References: <1458783966.1762.6.camel@perches.com> <1AE640813FDE7649BE1B193DEA596E883BB63FB7@SHSMSX101.ccr.corp.intel.com> In-Reply-To: <1AE640813FDE7649BE1B193DEA596E883BB63FB7@SHSMSX101.ccr.corp.intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.1.200.106] Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Transfer-Encoding: 8bit X-MIME-Autoconverted: from base64 to 8bit by mail.home.local id u2O6a3Gn025605 Content-Length: 1344 Lines: 35 > > > > > > -acpi_status acpi_hw_read(u32 *value, struct acpi_generic_address > *reg) > > > +acpi_status acpi_hw_read(u32 *value, struct acpi_generic_address * > reg) > > > > The second argument * style appears the opposite of normal style > > and a different style than the first argument * style. > [Lv Zheng] > The file is drivers/acpi/acpica/hwregs.c, which is coming from ACPICA > upstream. > So this is a result of "ACPICA release". > In other words, this is a result of a "process". > In order to fix this, things need to be done in "ACPICA release scripts". > Which should be done in > https://github.com/acpica/acpica/blob/master/generate/linux/libacpica.sh. > Otherwise, "ACPICA release" process will require human intervention. > > So please leave this patch fragment as is. > It will be automatically fixed if the "ACPICA release" process is fixed. > And if you don't leave this fragment as is, the "ACPICA release" process > will get hurt. I disagree. The patch should be correct when it hits the Linux kernel tree. If the process is broken, then fix the process and re-send a fixed patch. Linux doesn't care if the process is a program that runs with the click of a button, or the result of 1000 engineering laboring day and night. Only the result matters, the result should be correct, and this patch is not correct. -Len