Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756880AbcCXIi1 (ORCPT ); Thu, 24 Mar 2016 04:38:27 -0400 Received: from mx1.redhat.com ([209.132.183.28]:44697 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752144AbcCXIiZ (ORCPT ); Thu, 24 Mar 2016 04:38:25 -0400 Message-ID: <56F3A77D.6060802@redhat.com> Date: Thu, 24 Mar 2016 09:38:21 +0100 From: Denys Vlasenko User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Thunderbird/24.2.0 MIME-Version: 1.0 To: Zhaoxiu Zeng , Arnd Bergmann , Andrew Morton , Martin Kepplinger , Sasha Levin , Ingo Molnar , Yury Norov CC: linux-kernel@vger.kernel.org, linux-arch@vger.kernel.org Subject: Re: [PATCH 01/31] bitops: add parity functions References: <1458788612-4367-1-git-send-email-zhaoxiu.zeng@gmail.com> In-Reply-To: <1458788612-4367-1-git-send-email-zhaoxiu.zeng@gmail.com> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 246 Lines: 7 On 03/24/2016 04:03 AM, Zhaoxiu Zeng wrote: > +/* > + * Type invariant interface to the compile time constant parity functions. > + */ > +#define PARITY(w) PARITY64((u64)w) Can result in incorrect expansion of w. Should be PARITY64((u64)(w))