Date: Thu, 24 Mar 2016 10:39:15 +0100
From: Pali =?utf-8?B?Um9ow6Fy?= <pali.rohar@gmail.com>
To: Gabriele Mazzotta <gabriele.mzt@gmail.com>
Cc: Darren Hart <dvhart@infradead.org>,
        "D. Jared Dominguez" <Jared_Dominguez@dell.com>,
        "platform-driver-x86@vger.kernel.org" 
	<platform-driver-x86@vger.kernel.org>,
        "Rafael J. Wysocki" <rjw@rjwysocki.net>,
        Alex Hung <alex.hung@canonical.com>,
        Andrei Borzenkov <arvidjaar@gmail.com>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v3] dell-rbtn: Ignore ACPI notifications if device is
 suspended
Message-ID: <20160324093915.GZ8413@pali>
References: <1457740175-8327-1-git-send-email-gabriele.mzt@gmail.com>
 <1458341063-8753-1-git-send-email-gabriele.mzt@gmail.com>
 <20160321121736.GH8413@pali>
 <CABFtUbRxqJfd=CruaVnQPMbRo1ZaK=NX8wO7kwRh6pDN4s0t2g@mail.gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <CABFtUbRxqJfd=CruaVnQPMbRo1ZaK=NX8wO7kwRh6pDN4s0t2g@mail.gmail.com>
User-Agent: Mutt/1.5.23.1 (2014-03-12)
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1954
Lines: 53

On Monday 21 March 2016 16:13:34 Gabriele Mazzotta wrote:
> 2016-03-21 13:17 GMT+01:00 Pali Rohár <pali.rohar@gmail.com>:
> > On Friday 18 March 2016 23:44:23 Gabriele Mazzotta wrote:
> >> +#ifdef CONFIG_PM_SLEEP
> >> +static void ACPI_SYSTEM_XFACE rbtn_acpi_clear_flag(void *context)
> >> +{
> >> +     struct rbtn_data *rbtn_data = context;
> >> +
> >> +     rbtn_data->suspended = false;
> >> +}
> >> +
> >> +static int rbtn_suspend(struct device *dev)
> >> +{
> >> +     struct acpi_device *device = to_acpi_device(dev);
> >> +     struct rbtn_data *rbtn_data = acpi_driver_data(device);
> >> +
> >> +     rbtn_data->suspended = true;
> >> +
> >> +     return 0;
> >> +}
> >> +
> >> +static int rbtn_resume(struct device *dev)
> >> +{
> >> +     struct acpi_device *device = to_acpi_device(dev);
> >> +     struct rbtn_data *rbtn_data = acpi_driver_data(device);
> >> +     acpi_status status;
> >> +
> >> +     /*
> >> +      * Clear the flag only after we received the extra
> >> +      * ACPI notification.
> >> +      */
> >> +     status = acpi_os_execute(OSL_NOTIFY_HANDLER,
> >> +                      rbtn_acpi_clear_flag, rbtn_data);
> >> +     if (ACPI_FAILURE(status))
> >> +             rbtn_data->suspended = false;
> >
> > I case when acpi_os_execute success it calls rbtn_acpi_clear_flag,
> > right? And that will set suspended to false. When acpi_os_execute fails,
> > then it set suspended too to false... Then whole acpi_os_execute doing
> > just "barrier" after which suspended flag can be set to false. So I
> > think rbtn_acpi_clear_flag function is not needed here.
> >
> > Cannot you pass NULL or empty function pointer as callback? Or what was
> > reason to do that flag clearing at "two places"?
> 
> acpi_os_execute doesn't wait for the callback to be executed, so
> I can't clear the flag from rbtn_resume.

acpi_os_execute calls callback asynchronously later? Or what exactly do it?

-- 
Pali Rohár
pali.rohar@gmail.com