Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757067AbcCXKDM (ORCPT ); Thu, 24 Mar 2016 06:03:12 -0400 Received: from mga03.intel.com ([134.134.136.65]:46527 "EHLO mga03.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755189AbcCXKDG (ORCPT ); Thu, 24 Mar 2016 06:03:06 -0400 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.24,384,1455004800"; d="scan'208";a="944067505" From: Jani Nikula To: Sebastian Reichel Cc: Laurent Pinchart , Aaro Koskinen , Tony Lindgren , linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, Tomi Valkeinen , linux-omap@vger.kernel.org Subject: Re: [PATCH 02/23] ARM: dts: n950: add display support In-Reply-To: <20160323140105.GA31703@earth> Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo References: <1457455195-1938-1-git-send-email-sre@kernel.org> <1457455195-1938-3-git-send-email-sre@kernel.org> <21766689.NesyW3QHk4@avalon> <20160317174901.GB3864@earth> <87lh59pdt6.fsf@intel.com> <20160323140105.GA31703@earth> User-Agent: Notmuch/0.21+80~g3ff6f8b (http://notmuchmail.org) Emacs/24.4.1 (x86_64-pc-linux-gnu) Date: Thu, 24 Mar 2016 12:03:01 +0200 Message-ID: <87h9fwdwh6.fsf@intel.com> MIME-Version: 1.0 Content-Type: text/plain Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1396 Lines: 39 On Wed, 23 Mar 2016, Sebastian Reichel wrote: > On Wed, Mar 23, 2016 at 02:40:53PM +0200, Jani Nikula wrote: >> On Thu, 17 Mar 2016, Sebastian Reichel wrote: >> > On Thu, Mar 17, 2016 at 02:14:26PM +0200, Laurent Pinchart wrote: >> >> [...] >> >> > + >> >> > + /* panel is 480x464 with top and bottom 5 lines not visible */ >> >> >> >> I assume you mean 480x864 ? >> > >> > Yes, nice catch. Basically the screen is 480x864, but only >> > 480x854 are visible. >> >> It's been a while, but I thought the full 480x864 was actually usable >> and visible. > > I tried that first and the first few lines were missing. The stock > kernel also uses only 854px: > > https://github.com/nemomobile/kernel-adaptation-n950-n9/blob/mer-n9-2.6.32-20121301/arch/arm/mach-omap2/board-rm680-video.c > > (search for partial_area) Heh, I was reminded by old colleagues that it was actually my commit back in the day that changed the resolution 864->854 in the stock kernel. And that I did it reluctantly, because there really was no technical reason to do the change. I don't really care all that much either way anymore. I just thought you'd like to get those 4800 pixels back that you've been missing all these years. Plus 864 was nicer to deal with because it has 2^5 as a prime factor while 854 only has 2. BR, Jani. -- Jani Nikula, Intel Open Source Technology Center