Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755700AbcCXLOy (ORCPT ); Thu, 24 Mar 2016 07:14:54 -0400 Received: from foss.arm.com ([217.140.101.70]:50690 "EHLO foss.arm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755199AbcCXLOr (ORCPT ); Thu, 24 Mar 2016 07:14:47 -0400 Date: Thu, 24 Mar 2016 11:15:07 +0000 From: Will Deacon To: Jisheng Zhang Cc: catalin.marinas@arm.com, lorenzo.pieralisi@arm.com, daniel.lezcano@linaro.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 0/2] arm64: cpuidle: make arm_cpuidle_suspend() more efficient Message-ID: <20160324111507.GB9323@arm.com> References: <1458796130-6109-1-git-send-email-jszhang@marvell.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1458796130-6109-1-git-send-email-jszhang@marvell.com> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 556 Lines: 15 On Thu, Mar 24, 2016 at 01:08:48PM +0800, Jisheng Zhang wrote: > This series is to improve the arm_cpuidle_suspend() a bit by removing/moving > out checks from this hot path. > > Jisheng Zhang (2): > arm64: cpuidle: remove cpu_ops check from arm_cpuidle_suspend() > arm64: cpuidle: make arm_cpuidle_suspend() a bit more efficient > > arch/arm64/kernel/cpuidle.c | 9 ++------- > 1 file changed, 2 insertions(+), 7 deletions(-) These look fine to me, but do you have any rough numbers showing what sort of improvement we get from this change? Will