Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752159AbcCXMXB (ORCPT ); Thu, 24 Mar 2016 08:23:01 -0400 Received: from smtp.citrix.com ([66.165.176.89]:48386 "EHLO SMTP.CITRIX.COM" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751204AbcCXMWv (ORCPT ); Thu, 24 Mar 2016 08:22:51 -0400 X-IronPort-AV: E=Sophos;i="5.24,385,1454976000"; d="scan'208";a="341702270" Date: Thu, 24 Mar 2016 12:21:38 +0000 From: Stefano Stabellini X-X-Sender: sstabellini@kaball.uk.xensource.com To: Shannon Zhao CC: , , , , , , , , , , , , , , Subject: Re: [PATCH v6 00/17] Add ACPI support for Xen Dom0 on ARM64 In-Reply-To: <1458208636-12960-1-git-send-email-zhaoshenglong@huawei.com> Message-ID: References: <1458208636-12960-1-git-send-email-zhaoshenglong@huawei.com> User-Agent: Alpine 2.02 (DEB 1266 2009-07-14) MIME-Version: 1.0 Content-Type: text/plain; charset="US-ASCII" X-DLP: MIA2 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 5671 Lines: 129 On Thu, 17 Mar 2016, Shannon Zhao wrote: > From: Shannon Zhao > > This patch set adds ACPI support for Xen Dom0 on ARM64. The relevant Xen > ACPI on ARM64 design document could be found from [1]. > > This patch set adds a new FDT node "uefi" under /hypervisor to pass UEFI > information. Introduce a bus notifier of AMBA and Platform bus to map > the new added device's MMIO space. Make Xen domain use > xlated_setup_gnttab_pages to setup grant table and a new hypercall to > get event-channel irq. > > Regarding the initialization flow of Linux kernel, it needs to move > xen_early_init() before efi_init(). Then xen_early_init() will check > whether it runs on Xen through the /hypervisor node and efi_init() will > call a new function fdt_find_xen_uefi_params(), to parse those > xen,uefi-* parameters just like the existing efi_get_fdt_params(). > > And in arm64_enable_runtime_services() it will check whether it runs on > Xen and call another new function xen_efi_runtime_setup() to setup > runtime service instead of efi_native_runtime_setup(). The > xen_efi_runtime_setup() will assign the runtime function pointers with > the functions of driver/xen/efi.c. > > And since we pass a /hypervisor node and a /chosen node to Dom0, it > needs to check whether the DTS only contains a /hypervisor node and a > /chosen node in acpi_boot_table_init(). > > Patches are tested on FVP base model. I have no further comments on this series. Please address the minor point by Rafael, and resubmit. > Thanks, > Shannon > > [1] http://lists.xen.org/archives/html/xen-devel/2015-11/msg00488.html > > Changes since v5: > * rebase on linux master > * use acpi_dev_resource_memory to parse the device memory info(patch 1) > * sync with Xen (patch 9) > > Changes since v4: > * rebase on linux master > * move the check acpi_device_should_be_hidden into > acpi_bus_type_and_status (patch 1) > * use existing function fdt_subnode_offset (patch 16) > > Changes since v3: > * rebase on linux master > * print a warning when there is no SPCR table > * rephase the commit message of PATCH 3 > * rephase the words of PATCH 13 > * use strcmp and factor the function in PATCH 16 > * Add several ACKs and RBs, thanks a lot > > > Changes since v2: > * Use 0 to check if it should ignore the UART > * Fix the use of page_to_xen_pfn > * Factor ACPI and DT parts in xen_guest_init > * Check "uefi" node by full path > * Fix the statement of Documentation/devicetree/bindings/arm/xen.txt > > Changes since v1: > * Rebase on linux mainline and wallclock patch from Stefano > * Refactor AMBA and platform device MMIO map to one file > * Use EFI_PARAVIRT to check if it supports XEN EFI > * Refactor Xen EFI codes > * Address other comments > > Shannon Zhao (17): > Xen: ACPI: Hide UART used by Xen > xen/grant-table: Move xlated_setup_gnttab_pages to common place > Xen: xlate: Use page_to_xen_pfn instead of page_to_pfn > arm/xen: Use xen_xlate_map_ballooned_pages to setup grant table > xen: memory : Add new XENMAPSPACE type XENMAPSPACE_dev_mmio > Xen: ARM: Add support for mapping platform device mmio > Xen: ARM: Add support for mapping AMBA device mmio > Xen: public/hvm: sync changes of HVM_PARAM_CALLBACK_VIA ABI from Xen > xen/hvm/params: Add a new delivery type for event-channel in > HVM_PARAM_CALLBACK_IRQ > arm/xen: Get event-channel irq through HVM_PARAM when booting with > ACPI > ARM: XEN: Move xen_early_init() before efi_init() > ARM64: ACPI: Check if it runs on Xen to enable or disable ACPI > ARM: Xen: Document UEFI support on Xen ARM virtual platforms > XEN: EFI: Move x86 specific codes to architecture directory > ARM64: XEN: Add a function to initialize Xen specific UEFI runtime > services > FDT: Add a helper to get the subnode by given name > Xen: EFI: Parse DT parameters for Xen specific UEFI > > Documentation/devicetree/bindings/arm/xen.txt | 33 +++++ > arch/arm/include/asm/xen/xen-ops.h | 6 + > arch/arm/xen/Makefile | 1 + > arch/arm/xen/efi.c | 40 ++++++ > arch/arm/xen/enlighten.c | 109 +++++++++++---- > arch/arm64/include/asm/xen/xen-ops.h | 6 + > arch/arm64/kernel/acpi.c | 12 +- > arch/arm64/kernel/setup.c | 2 +- > arch/arm64/xen/Makefile | 1 + > arch/x86/xen/efi.c | 112 ++++++++++++++++ > arch/x86/xen/grant-table.c | 57 +------- > drivers/acpi/scan.c | 63 +++++++++ > drivers/firmware/efi/arm-runtime.c | 17 ++- > drivers/firmware/efi/efi.c | 45 ++++++- > drivers/of/fdt.c | 13 ++ > drivers/xen/Kconfig | 2 +- > drivers/xen/Makefile | 1 + > drivers/xen/arm-device.c | 184 ++++++++++++++++++++++++++ > drivers/xen/efi.c | 174 +++++------------------- > drivers/xen/xlate_mmu.c | 67 ++++++++++ > include/linux/of_fdt.h | 2 + > include/xen/interface/hvm/params.h | 40 +++++- > include/xen/interface/memory.h | 1 + > include/xen/xen-ops.h | 32 +++-- > 24 files changed, 773 insertions(+), 247 deletions(-) > create mode 100644 arch/arm/include/asm/xen/xen-ops.h > create mode 100644 arch/arm/xen/efi.c > create mode 100644 arch/arm64/include/asm/xen/xen-ops.h > create mode 100644 drivers/xen/arm-device.c > > -- > 2.0.4 > >