Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757445AbcCXNVi (ORCPT ); Thu, 24 Mar 2016 09:21:38 -0400 Received: from mga14.intel.com ([192.55.52.115]:55357 "EHLO mga14.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752274AbcCXNVa (ORCPT ); Thu, 24 Mar 2016 09:21:30 -0400 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.24,385,1455004800"; d="scan'208";a="930898552" Date: Thu, 24 Mar 2016 15:21:27 +0200 From: Jarkko Sakkinen To: Jason Gunthorpe Cc: Peter Huewe , Marcel Selhorst , "moderated list:TPM DEVICE DRIVER" , open list Subject: Re: [PATCH] tpm: drop 'base' from struct tpm_vendor_specific Message-ID: <20160324132127.GA8452@intel.com> References: <1458713769-11800-1-git-send-email-jarkko.sakkinen@linux.intel.com> <20160323164542.GC16336@obsidianresearch.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20160323164542.GC16336@obsidianresearch.com> Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo User-Agent: Mutt/1.5.24 (2015-08-30) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 788 Lines: 25 On Wed, Mar 23, 2016 at 10:45:42AM -0600, Jason Gunthorpe wrote: > On Wed, Mar 23, 2016 at 08:16:09AM +0200, Jarkko Sakkinen wrote: > > Dropped the field 'base' from struct tpm_vendor_specific and migrated > > it to the private structures of tpm_atmel and tpm_nsc. > > > > Signed-off-by: Jarkko Sakkinen > > > +#define atmel_get_priv(chip) ((struct tpm_atmel_priv *) chip->vendor.priv) > > This should be a static inline function not a define > > > +#define tpm_nsc_get_priv(chip) ((struct tpm_nsc_priv *) chip->vendor.priv) > > Ditto > > Otherwise looks ok > > Reviewed-by: Jason Gunthorpe Thank you. In my the commit now in my master branch they are now changed as static inline functions. > Jason /Jarkko