Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751700AbcCXO6I (ORCPT ); Thu, 24 Mar 2016 10:58:08 -0400 Received: from smtprelay.synopsys.com ([198.182.47.9]:40916 "EHLO smtprelay.synopsys.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750730AbcCXO57 convert rfc822-to-8bit (ORCPT ); Thu, 24 Mar 2016 10:57:59 -0400 From: Alexey Brodkin To: "robh@kernel.org" CC: "linux-kernel@vger.kernel.org" , "pawel.moll@arm.com" , "devicetree@vger.kernel.org" , "linux-snps-arc@lists.infradead.org" , "mark.rutland@arm.com" , "galak@codeaurora.org" , "ijc+devicetree@hellion.org.uk" , "dri-devel@lists.freedesktop.org" , "airlied@linux.ie" Subject: Re: [PATCH 2/4 v3] drm: Add DT bindings documentation for ARC PGU display controller Thread-Topic: [PATCH 2/4 v3] drm: Add DT bindings documentation for ARC PGU display controller Thread-Index: AQHRe6ywNAKBpjxmJ0qG2QN2G0B4wp9j3D6AgATWuQA= Date: Thu, 24 Mar 2016 14:57:52 +0000 Message-ID: <1458831472.12765.8.camel@synopsys.com> References: <1457710959-9562-1-git-send-email-abrodkin@synopsys.com> <1457710959-9562-3-git-send-email-abrodkin@synopsys.com> <20160321130419.GA23913@rob-hp-laptop> In-Reply-To: <20160321130419.GA23913@rob-hp-laptop> Accept-Language: en-US, ru-RU Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.121.8.113] Content-Type: text/plain; charset="utf-7" Content-ID: Content-Transfer-Encoding: 8BIT MIME-Version: 1.0 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 4069 Lines: 91 Hi Rob, On Mon, 2016-03-21 at 08:04 -0500, Rob Herring wrote: +AD4- On Fri, Mar 11, 2016 at 06:42:37PM +-0300, Alexey Brodkin wrote: +AD4- +AD4- +AD4- +AD4- This add DT bindings documentation for ARC PGU display controller. +AD4- +AD4- +AD4- +AD4- Signed-off-by: Alexey Brodkin +ADw-abrodkin+AEA-synopsys.com+AD4- +AD4- +AD4- Cc: Rob Herring +ADw-robh+-dt+AEA-kernel.org+AD4- +AD4- +AD4- Cc: Pawel Moll +ADw-pawel.moll+AEA-arm.com+AD4- +AD4- +AD4- Cc: Mark Rutland +ADw-mark.rutland+AEA-arm.com+AD4- +AD4- +AD4- Cc: Ian Campbell +ADw-ijc+-devicetree+AEA-hellion.org.uk+AD4- +AD4- +AD4- Cc: Kumar Gala +ADw-galak+AEA-codeaurora.org+AD4- +AD4- +AD4- Cc: David Airlie +ADw-airlied+AEA-linux.ie+AD4- +AD4- +AD4- Cc: dri-devel+AEA-lists.freedesktop.org +AD4- +AD4- Cc: devicetree+AEA-vger.kernel.org +AD4- +AD4- Cc: linux-snps-arc+AEA-lists.infradead.org +AD4- +AD4- --- +AD4- +AD4- +AD4- +AD4- Changes v2 -+AD4- v3: +AD4- +AD4- +AKAAKg- Reverted back to initial larger version of example +AD4- +AD4- +AKAAoACg-with minor fixes (thanks Rob for spotting those). +AD4- +AD4- +AD4- +AD4- Changes v1 -+AD4- v2: +AD4- +AD4- +AKAAKg- Removed everything except PGU node itself. +AD4- +AD4- +AD4- +AD4- +AKA-.../devicetree/bindings/display/snps,arcpgu.txt+AKAAoACgAKAAfA- 72 +-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+- +AD4- +AD4- +AKA-1 file changed, 72 insertions(+-) +AD4- +AD4- +AKA-create mode 100644 Documentation/devicetree/bindings/display/snps,arcpgu.txt +AD4- +AD4- +AD4- +AD4- diff --git a/Documentation/devicetree/bindings/display/snps,arcpgu.txt +AD4- +AD4- b/Documentation/devicetree/bindings/display/snps,arcpgu.txt +AD4- +AD4- new file mode 100644 +AD4- +AD4- index 0000000..b130924 +AD4- +AD4- --- /dev/null +AD4- +AD4- +-+-+- b/Documentation/devicetree/bindings/display/snps,arcpgu.txt +AD4- +AD4- +AEAAQA- -0,0 +-1,72 +AEAAQA- +AD4- +AD4- +-ARC PGU +AD4- +AD4- +- +AD4- +AD4- +-This is a display controller found on several development boards produced +AD4- +AD4- +-by Synopsys. The ARC PGU is an RGB streamer that reads the data from a +AD4- +AD4- +-framebuffer and sends it to a single digital encoder (usually HDMI). +AD4- +AD4- +- +AD4- +AD4- +-Required properties: +AD4- +AD4- +-+AKAAoA-- compatible: +ACI-snps,arcpgu+ACI- +AD4- +AD4- +-+AKAAoA-- reg: Physical base address and length of the controller's registers. +AD4- +AD4- +-+AKAAoA-- clocks: A list of phandle +- clock-specifier pairs, one for each +AD4- +AD4- +-+AKAAoACgAKA-entry in 'clock-names'. +AD4- +AD4- +-+AKAAoA-- clock-names: A list of clock names. For ARC PGU it should contain: +AD4- +AD4- +-+AKAAoACgAKAAoACg-- +ACI-pxlclk+ACI- for the clock feeding the output PLL of the controller. +AD4- +AD4- +-+AKAAoA-- encoder-slave: Phandle of encoder chip. +AD4- Drop this as discussed. Ok I'll do that. But what about my example below? Do I need to remove encoder node from it as well? +AD4- +AD4- +AD4- +AD4- +- +AD4- +AD4- +-Required sub-nodes: +AD4- +AD4- +-+AKAAoA-- port: The PGU connection to an encoder chip. +AD4- +AD4- +- +AD4- +AD4- +-Example: +AD4- +AD4- +- +AD4- +AD4- +-/ +AHs- +AD4- +AD4- +- ... +AD4- +AD4- +- +AD4- +AD4- +- pgu+AEA-XXXXXXXX +AHs- +AD4- +AD4- +- compatible +AD0- +ACI-snps,arcpgu+ACIAOw- +AD4- +AD4- +- reg +AD0- +ADw-0xXXXXXXXX 0x400+AD4AOw- +AD4- +AD4- +- clocks +AD0- +ADwAJg-clock+AF8-node+AD4AOw- +AD4- +AD4- +- clock-names +AD0- +ACI-pxlclk+ACIAOw- +AD4- +AD4- +- encoder-slave +AD0- +ADwAJg-encoder+AF8-node+AD4AOw- +AD4- +AD4- +- +AD4- +AD4- +- port +AHs- +AD4- +AD4- +- pgu+AF8-output: endpoint +AHs- +AD4- +AD4- +- remote-endpoint +AD0- +ADwAJg-hdmi+AF8-enc+AF8-input+AD4AOw- +AD4- +AD4- +- +AH0AOw- +AD4- +AD4- +- +AH0AOw- +AD4- +AD4- +- +AH0AOw- +AD4- +AD4- +- +AD4- +AD4- +- /+ACo- HDMI encoder on I2C bus +ACo-/ +AD4- +AD4- +- i2c+AEA-XXXXXXXX +AHs- +AD4- +AD4- +- compatible +AD0- +ACI-...+ACIAOw- +AD4- +AD4- +- +AD4- +AD4- +- encoder+AF8-node:encoder+AF8-node+AEA-0xXX+AHs- +AD4- Don't use underscores in node names. Just +ACI-hdmi+AEA-xx+ACI- Ok still I may keep label +ACI-encoder+AF8-node+ACI- here, right? -Alexey