Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752016AbcCXV3P (ORCPT ); Thu, 24 Mar 2016 17:29:15 -0400 Received: from gloria.sntech.de ([95.129.55.99]:37622 "EHLO gloria.sntech.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751340AbcCXV3N (ORCPT ); Thu, 24 Mar 2016 17:29:13 -0400 From: Heiko Stuebner To: kishon@ti.com Cc: linux-rockchip@lists.infradead.org, linux-kernel@vger.kernel.org, shawn.lin@rock-chips.com, ykk@rock-chips.com, devicetree@vger.kernel.org, robh+dt@kernel.org, pawel.moll@arm.com, mark.rutland@arm.com, ijc+devicetree@hellion.org.uk, galak@codeaurora.org, Heiko Stuebner Subject: [PATCH v2 3/3] phy: rockchip-emmc: adapt binding to specifiy register offset and length Date: Thu, 24 Mar 2016 22:29:03 +0100 Message-Id: <1458854943-17388-3-git-send-email-heiko@sntech.de> X-Mailer: git-send-email 2.7.0 In-Reply-To: <1458854943-17388-1-git-send-email-heiko@sntech.de> References: <1458854943-17388-1-git-send-email-heiko@sntech.de> Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1543 Lines: 49 The emmc-phy occupies a contiguous set of 8 registers inside the general register files, so the reg property should specify this. Signed-off-by: Heiko Stuebner --- This is essential a counter argument for Shawn's move from reg to reg_offset in "phy: rockchip-emmc: fix compile issue on arm64 platform" [0]. With the move under the grf we now also are able to specify this stuff cleanly using already present mechanisms. Also meant to v4.6-rc before the binding solidifies. [0] https://lkml.org/lkml/2016/3/8/114 Documentation/devicetree/bindings/phy/rockchip-emmc-phy.txt | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/Documentation/devicetree/bindings/phy/rockchip-emmc-phy.txt b/Documentation/devicetree/bindings/phy/rockchip-emmc-phy.txt index 461e958..555cb0f 100644 --- a/Documentation/devicetree/bindings/phy/rockchip-emmc-phy.txt +++ b/Documentation/devicetree/bindings/phy/rockchip-emmc-phy.txt @@ -4,7 +4,7 @@ Rockchip EMMC PHY Required properties: - compatible: rockchip,rk3399-emmc-phy - #phy-cells: must be 0 - - reg: PHY configure reg address offset in "general + - reg: PHY register address offset and length in "general register files" Example: @@ -12,12 +12,14 @@ Example: grf: syscon@ff770000 { compatible = "rockchip,rk3399-grf", "syscon", "simple-mfd"; + #address-cells = <1>; + #size-cells = <1>; ... emmcphy: phy@f780 { compatible = "rockchip,rk3399-emmc-phy"; - reg = <0xf780>; + reg = <0xf780 0x20>; #phy-cells = <0>; }; }; -- 2.7.0