Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751340AbcCXW2S (ORCPT ); Thu, 24 Mar 2016 18:28:18 -0400 Received: from mail.linuxfoundation.org ([140.211.169.12]:42170 "EHLO mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750794AbcCXW2Q (ORCPT ); Thu, 24 Mar 2016 18:28:16 -0400 Date: Thu, 24 Mar 2016 15:28:15 -0700 From: Andrew Morton To: Denys Vlasenko Cc: Zhaoxiu Zeng , Arnd Bergmann , Martin Kepplinger , Sasha Levin , Ingo Molnar , Yury Norov , linux-kernel@vger.kernel.org, linux-arch@vger.kernel.org Subject: Re: [PATCH 01/31] bitops: add parity functions Message-Id: <20160324152815.3489c6d54270f278e5dc7db4@linux-foundation.org> In-Reply-To: <56F3A77D.6060802@redhat.com> References: <1458788612-4367-1-git-send-email-zhaoxiu.zeng@gmail.com> <56F3A77D.6060802@redhat.com> X-Mailer: Sylpheed 3.4.1 (GTK+ 2.24.23; x86_64-pc-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 389 Lines: 11 On Thu, 24 Mar 2016 09:38:21 +0100 Denys Vlasenko wrote: > On 03/24/2016 04:03 AM, Zhaoxiu Zeng wrote: > > +/* > > + * Type invariant interface to the compile time constant parity functions. > > + */ > > +#define PARITY(w) PARITY64((u64)w) > > Can result in incorrect expansion of w. Should be PARITY64((u64)(w)) And we seem to be missing the other 30 patches.