Subject: Re: [PATCH 1/6] block: ensure we don't truncate top bits of the
 request command flags
To: Jens Axboe <axboe@fb.com>, Christoph Hellwig <hch@infradead.org>
References: <1458669320-6819-1-git-send-email-axboe@fb.com>
 <1458669320-6819-2-git-send-email-axboe@fb.com>
 <20160322185900.GB10113@infradead.org> <56F19672.7030508@fb.com>
Cc: linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org,
        linux-block@vger.kernel.org, martin.petersen@oracle.com
From: Mike Christie <mchristi@redhat.com>
Message-ID: <56F49DB5.6070303@redhat.com>
Date: Thu, 24 Mar 2016 21:08:53 -0500
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101
 Thunderbird/38.6.0
MIME-Version: 1.0
In-Reply-To: <56F19672.7030508@fb.com>
Content-Type: text/plain; charset=windows-1252
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 934
Lines: 20

On 03/22/2016 02:01 PM, Jens Axboe wrote:
> On 03/22/2016 12:59 PM, Christoph Hellwig wrote:
>> On Tue, Mar 22, 2016 at 11:55:15AM -0600, Jens Axboe wrote:
>>> Some of the flags that we want to use from the make_request_fn path
>>> are now larger than 32-bit, so change the functions involved to
>>> accept an u64 instead of an unsigned int.
>>
>> When did we start doing that?  We really should merge Mike's split
>> of the operation style flags into the cmd_type before making things
>> even worse in the flags area.
> 
> Just now, and I ran into it last week as well, for a test patch on cfq
> that passed in higher flags for get_request -> may_queue() as well. We
> can do Mike's split first, I think it's a good cleanup. As a standalone
> series, I needed it though.
> 

Hey, did you want any changes on that patchset? I was going to repost it
with the kbuild fix against linux-next, but I can make any changes you
wanted first.