Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752873AbcCYCsE (ORCPT ); Thu, 24 Mar 2016 22:48:04 -0400 Received: from szxga02-in.huawei.com ([119.145.14.65]:64963 "EHLO szxga02-in.huawei.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751337AbcCYCsC (ORCPT ); Thu, 24 Mar 2016 22:48:02 -0400 Message-ID: <56F4A6D4.2080908@huawei.com> Date: Fri, 25 Mar 2016 10:47:48 +0800 From: Weidong Wang User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:12.0) Gecko/20120428 Thunderbird/12.0.1 MIME-Version: 1.0 To: CC: , Subject: [PATCH net-next] phy: keep the BCMR_LOOPBACK bit while setup forced mode Content-Type: text/plain; charset="ISO-8859-1" Content-Transfer-Encoding: 7bit X-Originating-IP: [10.177.21.100] X-CFilter-Loop: Reflected X-Mirapoint-Virus-RAPID-Raw: score=unknown(0), refid=str=0001.0A090203.56F4A6DD.0040,ss=1,re=0.000,recu=0.000,reip=0.000,cl=1,cld=1,fgs=0, ip=0.0.0.0, so=2013-06-18 04:22:30, dmn=2013-03-21 17:37:32 X-Mirapoint-Loop-Id: 92d0f48fa6fed98cae24b0ab2784d042 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 798 Lines: 29 When tested the PHY SGMII Loopback,: 1.set the LOOPBACK bit, 2.set the autoneg to AUTONEG_DISABLE, it calls the genphy_setup_forced which will clear the bit. So just keep the LOOPBACK bit while setup forced mode. Signed-off-by: Weidong Wang --- drivers/net/phy/phy_device.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/net/phy/phy_device.c b/drivers/net/phy/phy_device.c index e551f3a..8da4b80 100644 --- a/drivers/net/phy/phy_device.c +++ b/drivers/net/phy/phy_device.c @@ -1124,7 +1124,9 @@ static int genphy_config_advert(struct phy_device *phydev) int genphy_setup_forced(struct phy_device *phydev) { int ctl = 0; + int val = phy_read(phydev, MII_BMCR); + ctl |= val & BMCR_LOOPBACK; phydev->pause = 0; phydev->asym_pause = 0; -- 2.7.0