Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753122AbcCYCy4 (ORCPT ); Thu, 24 Mar 2016 22:54:56 -0400 Received: from m199-177.yeah.net ([123.58.177.199]:34808 "EHLO m199-177.yeah.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751337AbcCYCyz (ORCPT ); Thu, 24 Mar 2016 22:54:55 -0400 Subject: Re: [PATCH 0/5] drivers/mtd: make several functions return bool To: Yaowei Bai , dwmw2@infradead.org, computersforpeace@gmail.com, richard@nod.at, boris.brezillon@free-electrons.com References: <1458873715-3670-1-git-send-email-baiyaowei@cmss.chinamobile.com> Cc: linux-mtd@lists.infradead.org, linux-kernel@vger.kernel.org, Richard Weinberger , computersforpeace@gmail.com From: Dongsheng Yang Message-ID: <56F4A87B.5090100@easystack.cn> Date: Fri, 25 Mar 2016 10:54:51 +0800 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.5.0 MIME-Version: 1.0 In-Reply-To: <1458873715-3670-1-git-send-email-baiyaowei@cmss.chinamobile.com> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit X-HM-Spam-Status: e1koWUFPN1dZCBgUCR5ZQUpKVU9MQkJCQk5PSUlITUhJQ1dZCQ4XHghZQV koKz0kKzooKCQyNSQzPjo*PilBS1VLQDYjJCI#KCQyNSQzPjo*PilBS1VLQCsvKSQiPigkMjUkMz 46Pz4pQUtVS0A4NC41LykiJDg1QUtVS0ApPjwyNDUkOigyOkFLVUtAKyk0LTI1OD4kMTI6NTwoLk FLVUtAPyI1OjYyOCQyKyQ1NCQyNSQzPjo*PilBS1VLQCk#OjckMiskMjUkKTk3JDI1JDM#Oj8#KU FKSVVLQDYuNy8yJCk4Ky8kPzI9PT4pPjUvJDI1JDM#Oj8#KUFJVUtAMiskSiQ2MjUuLz4kODUvJE skSktBS1VLQDIrJEhLJDYyNS4vPiQ4NS8kSyROS0FLVUtAMiskLzQ*OiIkODUvJEskSktLQUtVS0 AyKyROJDYyNS4vPiQ4NS8kSyRKS0FLVUtAMiskSiQzNC4pJDg1LyRLJEpLS0FLVUtAKC45MT44Ly ROJDYyNS4vPiQ4NS8kSyRKS0FLVUtAKC45MT44LyQvND86IiQ4NS8kSyRKS0tBS1VLQCguOTE#OC 8kSiQzNC4pJDg1LyRLJEpLS0FLVUtAPSskKT4kPSwkMzcxJEtDS0hLTUFWTFVOQD01JCguOSQ#NS w0KT8oJDM3MSRKS0tJS0pBS1VJQ0AoLjkkPkFKVU5OQD01JDkyL0wkMzcxJEtMSklLSUFIVUpOWQ Y+ X-HM-Sender-Digest: e1kSHx4VD1lBWUc6NjI6DSo4OTo8EQNMDBlPE1E2NzwwFAJVSlVKT05D Q0xPT0JKTklMVTMWGhIXVR8UFRwIEx4VHFUCGhUcOx4aCAIIDxoYEFUYFUVZV1kMHhlZQR0aFwge V1kIAVlBSU5JSDdXWRILWUFZTkNVSUpIVUxJVUlKT1kG X-HM-Tid: 0a53abb22163642719da81104c40 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 932 Lines: 28 ccing: Brian and Richard Hi Yao, Is that really necessary? I am not sure how much benefit we can achieve from this change. Could you explain more? Yang On 03/25/2016 10:41 AM, Yaowei Bai wrote: > This series only make several funcitons return bool to improve > readability, no other funcitonal changes. > > Yaowei Bai (5): > drivers/mtd: mtd_is_partition can be boolean > drivers/mtd: cfi_interleave_supported can be boolean > drivers/mtd: map_bankwidth_supported can be boolean > drivers/mtd: mtd_nand_has_bch can be boolean > drivers/mtd/nand: nand_opcode_8bits can be boolean > > drivers/mtd/mtdpart.c | 6 +++--- > include/linux/mtd/cfi.h | 6 +++--- > include/linux/mtd/map.h | 6 +++--- > include/linux/mtd/nand.h | 6 +++--- > include/linux/mtd/nand_bch.h | 4 ++-- > include/linux/mtd/partitions.h | 2 +- > 6 files changed, 15 insertions(+), 15 deletions(-) >