Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753556AbcCYDGx (ORCPT ); Thu, 24 Mar 2016 23:06:53 -0400 Received: from mail-vk0-f54.google.com ([209.85.213.54]:33326 "EHLO mail-vk0-f54.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751422AbcCYDGv (ORCPT ); Thu, 24 Mar 2016 23:06:51 -0400 MIME-Version: 1.0 In-Reply-To: <1458801832.16645.7.camel@mtksdaap41> References: <1458726794-48298-1-git-send-email-yh.huang@mediatek.com> <1458801832.16645.7.camel@mtksdaap41> From: Daniel Kurtz Date: Fri, 25 Mar 2016 11:06:30 +0800 X-Google-Sender-Auth: gdrJd4sjKm8cvPMC8-TZTtygpJQ Message-ID: Subject: Re: [PATCH] sbs-battery: fix power status when battery is dry To: YH Huang Cc: Sebastian Reichel , Dmitry Eremin-Solenikov , David Woodhouse , Matthias Brugger , linux-pm@vger.kernel.org, "linux-kernel@vger.kernel.org" , "linux-arm-kernel@lists.infradead.org" , "moderated list:ARM/Mediatek SoC support" Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2477 Lines: 59 On Thu, Mar 24, 2016 at 2:43 PM, YH Huang wrote: > > Hi Daniel, > > On Thu, 2016-03-24 at 12:01 +0800, Daniel Kurtz wrote: > > Hi YH, > > > > On Wed, Mar 23, 2016 at 5:53 PM, YH Huang wrote: > > > When the battery is dry and BATTERY_FULL_DISCHARGED is set, > > > we should check BATTERY_DISCHARGING to decide the power status. > > > If BATTERY_DISCHARGING is set, the power status is not charging. > > > Or the power status should be charging. > > > > > > Signed-off-by: YH Huang > > > --- > > > drivers/power/sbs-battery.c | 22 ++++++++++++---------- > > > 1 file changed, 12 insertions(+), 10 deletions(-) > > > > > > diff --git a/drivers/power/sbs-battery.c b/drivers/power/sbs-battery.c > > > index d6226d6..d86db0e 100644 > > > --- a/drivers/power/sbs-battery.c > > > +++ b/drivers/power/sbs-battery.c > > > @@ -382,11 +382,12 @@ static int sbs_get_battery_property(struct i2c_client *client, > > > > > > if (ret & BATTERY_FULL_CHARGED) > > > val->intval = POWER_SUPPLY_STATUS_FULL; > > > - else if (ret & BATTERY_FULL_DISCHARGED) > > > - val->intval = POWER_SUPPLY_STATUS_NOT_CHARGING; > > > - else if (ret & BATTERY_DISCHARGING) > > > - val->intval = POWER_SUPPLY_STATUS_DISCHARGING; > > > - else > > > + else if (ret & BATTERY_DISCHARGING) { > > > + if (ret & BATTERY_FULL_DISCHARGED) > > > + val->intval = POWER_SUPPLY_STATUS_NOT_CHARGING; > > > + else > > > + val->intval = POWER_SUPPLY_STATUS_DISCHARGING; > > > + } else > > > > > > I think (BATTERY_DISCHARGING && BATTERY_FULL_DISCHARGED) is still > > POWER_SUPPLY_STATUS_DISCHARGING. > > So, let's just report what the battery says and do: > > > > else if (ret & BATTERY_DISCHARGING) > > val->intval = POWER_SUPPLY_STATUS_DISCHARGING; > > > So we just ignore the special situation (BATTERY_DISCHARGING && > BATTERY_FULL_DISCHARGED). > Isn't POWER_SUPPLY_STATUS_NOT_CHARGING a useful information? The battery is discharging. The fact that it is also reporting that it is already "discharged" just seems premature. I would expect to only see NOT_CHARGING if completely discharged *and* not discharging. > > > Regards, > YH Huang >