Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751962AbcCYFms (ORCPT ); Fri, 25 Mar 2016 01:42:48 -0400 Received: from mail-vk0-f67.google.com ([209.85.213.67]:35647 "EHLO mail-vk0-f67.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751087AbcCYFmp (ORCPT ); Fri, 25 Mar 2016 01:42:45 -0400 MIME-Version: 1.0 In-Reply-To: <1458875989.3209.11.camel@perches.com> References: <20160325024406.GA23833@SEL-JYOUN-D1> <1458875989.3209.11.camel@perches.com> Date: Fri, 25 Mar 2016 14:42:44 +0900 Message-ID: Subject: Re: [PATCH 1/2] staging: dgnc: fix 'line over 80 characters' From: DaeSeok Youn To: Joe Perches Cc: Lidza Louina , Mark Hounschell , Greg KH , "driverdev-devel@linuxdriverproject.org" , devel , linux-kernel , kernel-janitors Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2068 Lines: 55 2016-03-25 12:19 GMT+09:00 Joe Perches : > On Fri, 2016-03-25 at 11:44 +0900, Daeseok Youn wrote: >> fix checkpatch.pl warning about 'line over 80 characters' >> in dgnc_neo.c > [] >> diff --git a/drivers/staging/dgnc/dgnc_neo.c b/drivers/staging/dgnc/dgnc_neo.c > [] >> @@ -77,7 +77,8 @@ struct board_ops dgnc_neo_ops = { >> .send_immediate_char = neo_send_immediate_char >> }; >> >> -static uint dgnc_offset_table[8] = { 0x01, 0x02, 0x04, 0x08, 0x10, 0x20, 0x40, 0x80 }; >> +static uint dgnc_offset_table[8] = { 0x01, 0x02, 0x04, 0x08, >> + 0x10, 0x20, 0x40, 0x80 }; > Hi, Joe. > It may be better to remove this array and use BIT or << where > dgnc_offset_table is used instead. Yes, I will remove this array, and use BIT or '<<' instead of using table. But "a patch" as to have one meaning so I think this patch will be sent with another one. > > If not, this should be const. > > static const uint dgnc_offset_table[] = { > 0x01, 0x02, 0x04, 0x08, 0x10, 0x20, 0x40, 0x80 > }; > >> @@ -116,7 +117,8 @@ static inline void neo_set_cts_flow_control(struct channel_t *ch) >> writeb(efr, &ch->ch_neo_uart->efr); >> >> /* Turn on table D, with 8 char hi/low watermarks */ >> - writeb((UART_17158_FCTR_TRGD | UART_17158_FCTR_RTS_4DELAY), &ch->ch_neo_uart->fctr); >> + writeb((UART_17158_FCTR_TRGD | UART_17158_FCTR_RTS_4DELAY), >> + &ch->ch_neo_uart->fctr); > > You could remove parentheses here around the CONST | CONST OK. I got it. but it also, I will send a patch after fixing this, not in this, right? > >> @@ -150,7 +152,8 @@ static inline void neo_set_rts_flow_control(struct channel_t *ch) >> /* Turn on UART enhanced bits */ >> writeb(efr, &ch->ch_neo_uart->efr); >> >> - writeb((UART_17158_FCTR_TRGD | UART_17158_FCTR_RTS_4DELAY), &ch->ch_neo_uart->fctr); >> + writeb((UART_17158_FCTR_TRGD | UART_17158_FCTR_RTS_4DELAY), >> + &ch->ch_neo_uart->fctr); > > and here and all the other writeb uses Thanks. regards, Daeseok. >