Date: Fri, 25 Mar 2016 14:31:53 +0800
From: Yaowei Bai <baiyaowei@cmss.chinamobile.com>
To: Dongsheng Yang <dongsheng.yang@easystack.cn>
Cc: dwmw2@infradead.org, computersforpeace@gmail.com, richard@nod.at,
        boris.brezillon@free-electrons.com, linux-mtd@lists.infradead.org,
        linux-kernel@vger.kernel.org
Subject: Re: [PATCH 0/5] drivers/mtd: make several functions return bool
Message-ID: <20160325063153.GA3319@yaowei-K42JY>
References: <1458873715-3670-1-git-send-email-baiyaowei@cmss.chinamobile.com>
 <56F4A87B.5090100@easystack.cn>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <56F4A87B.5090100@easystack.cn>
User-Agent: Mutt/1.5.21 (2010-09-15)
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1269
Lines: 38

On Fri, Mar 25, 2016 at 10:54:51AM +0800, Dongsheng Yang wrote:
> ccing: Brian and Richard
> 
> Hi Yao,
>     Is that really necessary? I am not sure how much benefit we can
> achieve from this change.
> Could you explain more?

Yes, according to these functions' name, a boolean return value is more
suitable and matchable.

Also personally think this change maybe benfit function's return value 
storage in the stack when called on certain architectures.

> 
> Yang
> 
> On 03/25/2016 10:41 AM, Yaowei Bai wrote:
> >This series only make several funcitons return bool to improve
> >readability, no other funcitonal changes.
> >
> >Yaowei Bai (5):
> >   drivers/mtd: mtd_is_partition can be boolean
> >   drivers/mtd: cfi_interleave_supported can be boolean
> >   drivers/mtd: map_bankwidth_supported can be boolean
> >   drivers/mtd: mtd_nand_has_bch can be boolean
> >   drivers/mtd/nand: nand_opcode_8bits can be boolean
> >
> >  drivers/mtd/mtdpart.c          | 6 +++---
> >  include/linux/mtd/cfi.h        | 6 +++---
> >  include/linux/mtd/map.h        | 6 +++---
> >  include/linux/mtd/nand.h       | 6 +++---
> >  include/linux/mtd/nand_bch.h   | 4 ++--
> >  include/linux/mtd/partitions.h | 2 +-
> >  6 files changed, 15 insertions(+), 15 deletions(-)
> >
>