Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751646AbcCYIs4 (ORCPT ); Fri, 25 Mar 2016 04:48:56 -0400 Received: from mail-wm0-f67.google.com ([74.125.82.67]:35208 "EHLO mail-wm0-f67.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751127AbcCYIsw (ORCPT ); Fri, 25 Mar 2016 04:48:52 -0400 Date: Fri, 25 Mar 2016 09:48:47 +0100 From: Ingo Molnar To: Frederic Weisbecker Cc: LKML , Peter Zijlstra , Linus Torvalds , Thomas Gleixner , Andrew Morton Subject: Re: [PATCH 0/3] nohz: Convert tick dependency mask to atomic_t Message-ID: <20160325084847.GA15235@gmail.com> References: <1458830281-4255-1-git-send-email-fweisbec@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1458830281-4255-1-git-send-email-fweisbec@gmail.com> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1090 Lines: 36 * Frederic Weisbecker wrote: > As per Linus suggestion, lets convert the tick dependency mask to > atomic_t. Introduce atomic_fetch_or() and confine fetch_or() back to > scheduler guts. > > git://git.kernel.org/pub/scm/linux/kernel/git/frederic/linux-dynticks.git > timers/nohz > > HEAD: 7b7e5da5733f58668181077ec394a718e08c392c > > Thanks, > Frederic > --- > > Frederic Weisbecker (3): > atomic: Introduce atomic_fetch_or > nohz: Convert tick dependency mask to atomic_t > Revert "atomic: Export fetch_or()" > > > include/linux/atomic.h | 34 +++++++++++++-------------- > include/linux/sched.h | 4 ++-- > kernel/sched/core.c | 18 ++++++++++++++ > kernel/time/tick-sched.c | 61 ++++++++++++++++++++++++------------------------ > kernel/time/tick-sched.h | 2 +- > 5 files changed, 68 insertions(+), 51 deletions(-) Could you please also convert the sched/core.c usage, so that we can get rid of the private fetch_or() definition? Please also double check that it does not result in worse code generation. Thanks, Ingo