Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751927AbcCYI6Z (ORCPT ); Fri, 25 Mar 2016 04:58:25 -0400 Received: from down.free-electrons.com ([37.187.137.238]:46449 "EHLO mail.free-electrons.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1750797AbcCYI6X (ORCPT ); Fri, 25 Mar 2016 04:58:23 -0400 Date: Fri, 25 Mar 2016 09:58:21 +0100 From: Boris Brezillon To: Richard Weinberger Cc: Yaowei Bai , Dongsheng Yang , dwmw2@infradead.org, computersforpeace@gmail.com, linux-mtd@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 0/5] drivers/mtd: make several functions return bool Message-ID: <20160325095821.59cdc391@bbrezillon> In-Reply-To: <56F4EF87.4000003@nod.at> References: <1458873715-3670-1-git-send-email-baiyaowei@cmss.chinamobile.com> <56F4A87B.5090100@easystack.cn> <20160325063153.GA3319@yaowei-K42JY> <56F4EF87.4000003@nod.at> X-Mailer: Claws Mail 3.12.0 (GTK+ 2.24.28; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1210 Lines: 34 On Fri, 25 Mar 2016 08:57:59 +0100 Richard Weinberger wrote: > Am 25.03.2016 um 07:31 schrieb Yaowei Bai: > > On Fri, Mar 25, 2016 at 10:54:51AM +0800, Dongsheng Yang wrote: > >> ccing: Brian and Richard > >> > >> Hi Yao, > >> Is that really necessary? I am not sure how much benefit we can > >> achieve from this change. > >> Could you explain more? > > > > Yes, according to these functions' name, a boolean return value is more > > suitable and matchable. > > > > Also personally think this change maybe benfit function's return value > > storage in the stack when called on certain architectures. > > On which archs? And what exactly is the benefit? > I agree that bool might be a better choice for new functions > but here you're touching existing and working(!) code. > The only outcome is git history pollution that makes git blame > less efficient. Indeed, you raised a good point. Having useless changes pollute git blame output may be problematic. Not sure I want to apply those patches anymore :-/. Anyway, Yao, I'm sure you can find other usefull things to contribute. -- Boris Brezillon, Free Electrons Embedded Linux and Kernel engineering http://free-electrons.com