Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752101AbcCYJeZ (ORCPT ); Fri, 25 Mar 2016 05:34:25 -0400 Received: from mail-lb0-f193.google.com ([209.85.217.193]:34747 "EHLO mail-lb0-f193.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751836AbcCYJeW (ORCPT ); Fri, 25 Mar 2016 05:34:22 -0400 MIME-Version: 1.0 In-Reply-To: <87fuvfw6g9.fsf@notabene.neil.brown.name> References: <87fuvfw6g9.fsf@notabene.neil.brown.name> Date: Fri, 25 Mar 2016 10:34:20 +0100 Message-ID: Subject: Re: [GIT PULL] Ceph fixes for -rc7 From: Ilya Dryomov To: NeilBrown Cc: Sage Weil , torvalds@linux-foundation.org, "linux-kernel@vger.kernel.org" , Ceph Development Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1260 Lines: 38 On Fri, Mar 25, 2016 at 5:02 AM, NeilBrown wrote: > On Sun, Mar 06 2016, Sage Weil wrote: > >> Hi Linus, >> >> Please pull the following Ceph patch from >> >> git://git.kernel.org/pub/scm/linux/kernel/git/sage/ceph-client.git for-linus >> >> This is a final commit we missed to align the protocol compatibility with >> the feature bits. It decodes a few extra fields in two different messages >> and reports EIO when they are used (not yet supported). >> >> Thanks! >> sage >> >> >> ---------------------------------------------------------------- >> Yan, Zheng (1): >> ceph: initial CEPH_FEATURE_FS_FILE_LAYOUT_V2 support > > Just wondering, but was CEPH_FEATURE_FS_FILE_LAYOUT_V2 supposed to have > exactly the same value as CEPH_FEATURE_NEW_OSDOPREPLY_ENCODING (and > CEPH_FEATURE_CRUSH_TUNABLES5)?? Yes, that was the point of getting it merged into -rc7. > Because when I backported this patch (and many others) to some ancient > enterprise kernel, it caused mounts to fail. If it really is meant to > be the same value, then I must have some other backported issue to find > and fix. It has to be backported in concert with changes that add support for the other two bits. How did mount fail? Thanks, Ilya