Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752128AbcCYLZN (ORCPT ); Fri, 25 Mar 2016 07:25:13 -0400 Received: from mezzanine.sirena.org.uk ([106.187.55.193]:38364 "EHLO mezzanine.sirena.org.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751966AbcCYLZK (ORCPT ); Fri, 25 Mar 2016 07:25:10 -0400 Date: Fri, 25 Mar 2016 11:24:59 +0000 From: Mark Brown To: Alexander Stein Cc: linux-kernel@vger.kernel.org Message-ID: <20160325112459.GD2566@sirena.org.uk> References: <1458739079-11712-1-git-send-email-broonie@kernel.org> <2609570.vvhKhym0nL@ws-stein> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="f2unX6n4w7rMQ5H3" Content-Disposition: inline In-Reply-To: <2609570.vvhKhym0nL@ws-stein> X-Cookie: Walk softly and carry a megawatt laser. User-Agent: Mutt/1.5.24 (2015-08-30) X-SA-Exim-Connect-IP: 2a01:348:6:8808:fab::3 X-SA-Exim-Mail-From: broonie@sirena.org.uk Subject: Re: [PATCH] regmap: mmio: Fix value endianness selection X-SA-Exim-Version: 4.2.1 (built Mon, 26 Dec 2011 16:24:06 +0000) X-SA-Exim-Scanned: Yes (on mezzanine.sirena.org.uk) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1400 Lines: 40 --f2unX6n4w7rMQ5H3 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Wed, Mar 23, 2016 at 03:20:46PM +0100, Alexander Stein wrote: > The difference in those drivers is that syscon manually sets=20 > config.val_format_endian before calling regmap_init_mmio. > spi-fsl-dspi does not. I guess this driver relies on this configuration b= eing=20 > done in regmap_get_val_endian. But this is never reached because after se= tting=20 Does this IP exist in configurations where it is anything other than big endian? If not then this probably shouldn't be in DT. > map->reg_read this code is skipped due to "goto skip_format_initializatio= n;" > IMHO a call to regmap_get_val_endian should be added to=20 > regmap_mmio_gen_context. That sounds reasonable. --f2unX6n4w7rMQ5H3 Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQEcBAEBCAAGBQJW9SAKAAoJECTWi3JdVIfQrZgH/iJJ5O4ra0kiGYplMUH3fpQA Rd9b78i9CswkoYFP2mAuOuDtFG6d5cvOvSMpXrNjpDkfRzQTKSL8wbWiZBopuxda Yqt3Z263cLljbROWs4qDbTrx6S7szRQyKZZw4IBmfdNomLBUHmhm7EUCmd5W+O5w vabiXAQxTzz0Jc/lT8C9OzvRkICzyfJCMhOOPMlAx4ELsYoFOCkVT5kvY2VDe3Pu HfWysDP7UuR69eT7tnDtdqHwykMnQSPbrZIeuMhohaEMnnlauX+wD/ahX+7cKQS2 zZsFaR/3f7ISs8CBBmqxw5WEVfX1AJjbCB4nLrjvnkdX3DQuouZFm8CTVjftWiU= =iLLt -----END PGP SIGNATURE----- --f2unX6n4w7rMQ5H3--