Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752581AbcCYMcH (ORCPT ); Fri, 25 Mar 2016 08:32:07 -0400 Received: from relay1.mentorg.com ([192.94.38.131]:54911 "EHLO relay1.mentorg.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752577AbcCYMcA (ORCPT ); Fri, 25 Mar 2016 08:32:00 -0400 Subject: Re: [PATCH] Revert "regulator: core: Add support for active-discharge configuration" To: Mark Brown References: <1458849121-11242-1-git-send-email-vladimir_zapolskiy@mentor.com> <20160325111050.GB2566@sirena.org.uk> CC: Liam Girdwood , Laxman Dewangan , From: Vladimir Zapolskiy Message-ID: <56F52FB3.6050008@mentor.com> Date: Fri, 25 Mar 2016 14:31:47 +0200 User-Agent: Mozilla/5.0 (X11; Linux i686; rv:38.0) Gecko/20100101 Icedove/38.5.0 MIME-Version: 1.0 In-Reply-To: <20160325111050.GB2566@sirena.org.uk> Content-Type: text/plain; charset="windows-1252" Content-Transfer-Encoding: 7bit X-Originating-IP: [137.202.0.76] Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 908 Lines: 26 On 25.03.2016 13:10, Mark Brown wrote: > On Thu, Mar 24, 2016 at 09:52:01PM +0200, Vladimir Zapolskiy wrote: >> This reverts commit 909f7ee0b5f30f735e16864a7ed18d2e6123e6d9. >> >> Apparently due to a wrongly resolved merge conflict between two >> branches, which contained the same commit, the commit contents >> partially was added two times in a row. > > Please submit patches using subject lines reflecting the style for the > subsystem. This makes it easier for people to identify relevant > patches. > I agree, but the subsystem name is found in the name of the reverted commit. % git log --oneline | grep ' Revert "' | head -n 100 shows that only 1 of 6 revert patches has subsystem name in subject two times. Do you ask me to resumbit the change changing the subject to 'regulator: core: Revert "regulator: core: Add support for active-discharg configuration"'? -- With best wishes, Vladimir