Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752855AbcCYNuI (ORCPT ); Fri, 25 Mar 2016 09:50:08 -0400 Received: from mx1.redhat.com ([209.132.183.28]:37620 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752514AbcCYNuG (ORCPT ); Fri, 25 Mar 2016 09:50:06 -0400 Subject: Re: [PATCH 1/4] KVM: MMU: fix permission_fault() To: Xiao Guangrong References: <1458911978-19430-1-git-send-email-guangrong.xiao@linux.intel.com> <56F53E87.6010304@redhat.com> <56F54027.3050001@linux.intel.com> Cc: gleb@kernel.org, mtosatti@redhat.com, kvm@vger.kernel.org, linux-kernel@vger.kernel.org From: Paolo Bonzini Message-ID: <56F54208.7020907@redhat.com> Date: Fri, 25 Mar 2016 14:50:00 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.6.0 MIME-Version: 1.0 In-Reply-To: <56F54027.3050001@linux.intel.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 415 Lines: 16 On 25/03/2016 14:41, Xiao Guangrong wrote: >>> >> >> So is this patch doing the same as "KVM: MMU: precompute page fault >> error code"? It was necessary after all. :) > > Sorry for my mistake... I missed the logic you changed :( > > I still prefer to calculating the error code on the fault path which is > rare, or think a way to encapsulate it to permission_fault()... Yes, I will apply your patch. Paolo