Date: Fri, 25 Mar 2016 09:51:01 -0500
From: Rob Herring <robh@kernel.org>
To: Heiko Stuebner <heiko@sntech.de>
Cc: kishon@ti.com, linux-rockchip@lists.infradead.org,
        linux-kernel@vger.kernel.org, shawn.lin@rock-chips.com,
        ykk@rock-chips.com, devicetree@vger.kernel.org, pawel.moll@arm.com,
        mark.rutland@arm.com, ijc+devicetree@hellion.org.uk,
        galak@codeaurora.org
Subject: Re: [PATCH v2 1/3] phy: rockchip-dp: should be a child device of the
 GRF
Message-ID: <20160325145101.GA31747@rob-hp-laptop>
References: <1458854943-17388-1-git-send-email-heiko@sntech.de>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <1458854943-17388-1-git-send-email-heiko@sntech.de>
User-Agent: Mutt/1.5.23 (2014-03-12)
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1224
Lines: 26

On Thu, Mar 24, 2016 at 10:29:01PM +0100, Heiko Stuebner wrote:
> The displayport-phy is fully enclosed in the general register files (GRF).
> Therefore as seen from the device-tree it shouldn't be a separate platform-
> device but instead a sub-device of the GRF - using the simply-mfd mechanism.
> 
> The driver entered the kernel in the current merge-window, so we can still
> adapt the binding without needing a fallback, as the binding hasn't been
> released with a full kernel yet.
> 
> While the edp phy is fully part of the GRF, it doesn't have any separate
> register set there, so doesn't get any register-area assigned.
> 
> Signed-off-by: Heiko Stuebner <heiko@sntech.de>
> ---
> While one of my intermediate versions did include that conversion
> already, it looks like it was lost when the dp-phy got split out into
> its own series and I missed that dropped change.
> 
> As mentioned in the patch description above, this is meant as a fixup for
> kernel 4.6.
> 
>  .../devicetree/bindings/phy/rockchip-dp-phy.txt        | 18 +++++++++++-------
>  drivers/phy/phy-rockchip-dp.c                          |  7 +++++--
>  2 files changed, 16 insertions(+), 9 deletions(-)

Acked-by: Rob Herring <robh@kernel.org>