Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753516AbcCYOwh (ORCPT ); Fri, 25 Mar 2016 10:52:37 -0400 Received: from relay1.mentorg.com ([192.94.38.131]:35529 "EHLO relay1.mentorg.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752006AbcCYOwg (ORCPT ); Fri, 25 Mar 2016 10:52:36 -0400 Subject: Re: [PATCH] Revert "regulator: core: Add support for active-discharge configuration" To: Mark Brown References: <1458849121-11242-1-git-send-email-vladimir_zapolskiy@mentor.com> <20160325111050.GB2566@sirena.org.uk> CC: Liam Girdwood , Laxman Dewangan , , Russell King From: Vladimir Zapolskiy Message-ID: <56F550B0.7050602@mentor.com> Date: Fri, 25 Mar 2016 16:52:32 +0200 User-Agent: Mozilla/5.0 (X11; Linux i686; rv:38.0) Gecko/20100101 Icedove/38.1.0 MIME-Version: 1.0 In-Reply-To: <20160325111050.GB2566@sirena.org.uk> Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit X-Originating-IP: [137.202.0.76] Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 901 Lines: 28 On 25.03.2016 13:10, Mark Brown wrote: > On Thu, Mar 24, 2016 at 09:52:01PM +0200, Vladimir Zapolskiy wrote: >> This reverts commit 909f7ee0b5f30f735e16864a7ed18d2e6123e6d9. >> >> Apparently due to a wrongly resolved merge conflict between two >> branches, which contained the same commit, the commit contents >> partially was added two times in a row. > > Please submit patches using subject lines reflecting the style for the > subsystem. This makes it easier for people to identify relevant > patches. > Okay, submitting of reverted patches is different I believe: http://www.spinics.net/lists/arm-kernel/msg75667.html RMK: I think it's sensible to keep at least the summary line of a 'git revert' intact rather than inventing our own. That discussion was about a8cf81ffe028 '(Revert "[ARM] unconditionally define __virt_to_phys and __phys_to_virt")' -- With best wishes, Vladimir