Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id ; Mon, 17 Mar 2003 11:53:00 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id ; Mon, 17 Mar 2003 11:53:00 -0500 Received: from nat-pool-rdu.redhat.com ([66.187.233.200]:53751 "EHLO devserv.devel.redhat.com") by vger.kernel.org with ESMTP id ; Mon, 17 Mar 2003 11:52:58 -0500 Date: Mon, 17 Mar 2003 12:03:44 -0500 From: Pete Zaitcev To: BOEBLINGEN LINUX390 Cc: Pete Zaitcev , linux-kernel@vger.kernel.org Subject: Re: [s390x] Patch for execve with a mode switch Message-ID: <20030317120344.A10911@devserv.devel.redhat.com> References: Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline User-Agent: Mutt/1.2.5.1i In-Reply-To: ; from LINUX390@de.ibm.com on Mon, Mar 17, 2003 at 04:20:37PM +0100 Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 962 Lines: 24 > From: "BOEBLINGEN LINUX390" > Date: Mon, 17 Mar 2003 16:20:37 +0100 > mm->free_area_cache can't cause any problems on s390x because it isn't > used. [...] > This patch is severly broken. It wouldn't even compile. I am sorry, yes, please don't apply to 2.5. It is only needed on later 2.4, which use the mm->free_area_cache (our old 2.4.9 works ok, but 2.4.20 doesn't). I still think you are making a mistake defininig your own arch_get_unmapped_area(), because: 1. sparc64 does it correctly with the common code, so it can be done; 2. architecture specific duplicates of common code may bitrot. But have it your way, I won't resubmit, for the sake of staying aligned with upstream. -- Pete - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/