Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753803AbcCYOxW (ORCPT ); Fri, 25 Mar 2016 10:53:22 -0400 Received: from mail.kernel.org ([198.145.29.136]:48766 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753688AbcCYOxT (ORCPT ); Fri, 25 Mar 2016 10:53:19 -0400 Date: Fri, 25 Mar 2016 09:53:13 -0500 From: Rob Herring To: Heiko Stuebner Cc: kishon@ti.com, linux-rockchip@lists.infradead.org, linux-kernel@vger.kernel.org, shawn.lin@rock-chips.com, ykk@rock-chips.com, devicetree@vger.kernel.org, pawel.moll@arm.com, mark.rutland@arm.com, ijc+devicetree@hellion.org.uk, galak@codeaurora.org Subject: Re: [PATCH v2 3/3] phy: rockchip-emmc: adapt binding to specifiy register offset and length Message-ID: <20160325145313.GA506@rob-hp-laptop> References: <1458854943-17388-1-git-send-email-heiko@sntech.de> <1458854943-17388-3-git-send-email-heiko@sntech.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1458854943-17388-3-git-send-email-heiko@sntech.de> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 795 Lines: 20 On Thu, Mar 24, 2016 at 10:29:03PM +0100, Heiko Stuebner wrote: > The emmc-phy occupies a contiguous set of 8 registers inside the general > register files, so the reg property should specify this. > > Signed-off-by: Heiko Stuebner > --- > This is essential a counter argument for Shawn's move from reg to reg_offset > in "phy: rockchip-emmc: fix compile issue on arm64 platform" [0]. > With the move under the grf we now also are able to specify this stuff > cleanly using already present mechanisms. > > Also meant to v4.6-rc before the binding solidifies. > > > [0] https://lkml.org/lkml/2016/3/8/114 > > Documentation/devicetree/bindings/phy/rockchip-emmc-phy.txt | 6 ++++-- > 1 file changed, 4 insertions(+), 2 deletions(-) Acked-by: Rob Herring