Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753155AbcCYPId (ORCPT ); Fri, 25 Mar 2016 11:08:33 -0400 Received: from userp1040.oracle.com ([156.151.31.81]:24777 "EHLO userp1040.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751989AbcCYPIc (ORCPT ); Fri, 25 Mar 2016 11:08:32 -0400 Subject: Re: [PATCH 2/2] xen/x86: Call cpu_startup_entry(CPUHP_AP_ONLINE_IDLE) from xen_play_dead() To: Konrad Rzeszutek Wilk References: <1458219805-13197-1-git-send-email-boris.ostrovsky@oracle.com> <1458219805-13197-3-git-send-email-boris.ostrovsky@oracle.com> <20160325145358.GC17902@char.us.oracle.com> Cc: david.vrabel@citrix.com, xen-devel@lists.xenproject.org, linux-kernel@vger.kernel.org From: Boris Ostrovsky Message-ID: <56F55470.5090004@oracle.com> Date: Fri, 25 Mar 2016 11:08:32 -0400 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.1.0 MIME-Version: 1.0 In-Reply-To: <20160325145358.GC17902@char.us.oracle.com> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit X-Source-IP: userv0022.oracle.com [156.151.31.74] Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1235 Lines: 44 On 03/25/2016 10:53 AM, Konrad Rzeszutek Wilk wrote: > On Thu, Mar 17, 2016 at 09:03:25AM -0400, Boris Ostrovsky wrote: >> This call has always been missing from xen_play dead() but until >> recently this was rather benign. With new cpu hotplug framework >> however this call is required, otherwise a hot-plugged CPU will not > Could you include the commit id of the 'new cpu hotplug' in case > anybody wants to backport this? Sure. It's commit 8df3e07e7f21 ("cpu/hotplug: Let upcoming cpu bring itself fully up"). Do you (or David) want me to re-send it? -boris > > Thanks! >> be properly brough up (by never calling cpuhp_online_idle()) >> >> Signed-off-by: Boris Ostrovsky >> --- >> arch/x86/xen/smp.c | 2 ++ >> 1 files changed, 2 insertions(+), 0 deletions(-) >> >> diff --git a/arch/x86/xen/smp.c b/arch/x86/xen/smp.c >> index 3c6d17f..719cf29 100644 >> --- a/arch/x86/xen/smp.c >> +++ b/arch/x86/xen/smp.c >> @@ -545,6 +545,8 @@ static void xen_play_dead(void) /* used only with HOTPLUG_CPU */ >> * data back is to call: >> */ >> tick_nohz_idle_enter(); >> + >> + cpu_startup_entry(CPUHP_AP_ONLINE_IDLE); >> } >> >> #else /* !CONFIG_HOTPLUG_CPU */ >> -- >> 1.7.1 >>