Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753445AbcCYPNi (ORCPT ); Fri, 25 Mar 2016 11:13:38 -0400 Received: from mail.kernel.org ([198.145.29.136]:50106 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752688AbcCYPNg (ORCPT ); Fri, 25 Mar 2016 11:13:36 -0400 MIME-Version: 1.0 In-Reply-To: <56F53D20.6030709@cogentembedded.com> References: <1458863503-31121-1-git-send-email-david@lechnology.com> <1458863503-31121-2-git-send-email-david@lechnology.com> <56F53D20.6030709@cogentembedded.com> From: Rob Herring Date: Fri, 25 Mar 2016 10:13:11 -0500 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH v3 01/16] dt: davinci: use proper address after @ To: Sergei Shtylyov Cc: David Lechner , Petr Kulhavy , David.Laight@aculab.com, Pawel Moll , Mark Rutland , Ian Campbell , Kumar Gala , Russell King , Sekhar Nori , Kevin Hilman , Kishon Vijay Abraham I , Greg Kroah-Hartman , Alan Stern , Bin Liu , Lee Jones , "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" , open list , "moderated list:ARM PORT" , "open list:USB SUBSYSTEM" Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1293 Lines: 41 On Fri, Mar 25, 2016 at 8:29 AM, Sergei Shtylyov wrote: > Hello. > > On 03/25/2016 02:51 AM, David Lechner wrote: > >> TI has been using the physical address in DT after the @ in device nodes. >> The device tree convention is to use the same address that is used for >> the reg property. This updates all davinci DT files to use the proper >> convention. >> >> Signed-off-by: David Lechner > > [...] > >> diff --git a/arch/arm/boot/dts/da850.dtsi b/arch/arm/boot/dts/da850.dtsi >> index 226cda7..4294849 100644 >> --- a/arch/arm/boot/dts/da850.dtsi >> +++ b/arch/arm/boot/dts/da850.dtsi >> @@ -15,7 +15,7 @@ >> #address-cells = <1>; >> #size-cells = <1>; >> ranges; >> - intc: interrupt-controller { >> + intc: interrupt-controller@fffee000 { >> compatible = "ti,cp-intc"; >> interrupt-controller; >> #interrupt-cells = <1>; >> @@ -23,7 +23,7 @@ >> reg = <0xfffee000 0x2000>; >> }; >> }; >> - soc { >> + soc@1c00000 { > > > This node doesn't have the "reg" prop. But probably has a ranges property which is correct. Rob