Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753372AbcCYPo2 (ORCPT ); Fri, 25 Mar 2016 11:44:28 -0400 Received: from shards.monkeyblade.net ([149.20.54.216]:42210 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751857AbcCYPo1 (ORCPT ); Fri, 25 Mar 2016 11:44:27 -0400 Date: Fri, 25 Mar 2016 11:44:23 -0400 (EDT) Message-Id: <20160325.114423.859412154606595295.davem@davemloft.net> To: cyrille.pitchen@atmel.com Cc: nicolas.ferre@atmel.com, linux-arm-kernel@lists.infradead.org, netdev@vger.kernel.org, soren.brinkmann@xilinx.com, linux-kernel@vger.kernel.org, narmstrong@baylibre.com Subject: Re: [PATCH v2 1/1] net: macb: remove BUG_ON() and reset the queue to handle RX errors From: David Miller In-Reply-To: <1458898654-25864-1-git-send-email-cyrille.pitchen@atmel.com> References: <1458898654-25864-1-git-send-email-cyrille.pitchen@atmel.com> X-Mailer: Mew version 6.7 on Emacs 24.5 / Mule 6.0 (HANACHIRUSATO) Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Fri, 25 Mar 2016 08:44:26 -0700 (PDT) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 702 Lines: 18 From: Cyrille Pitchen Date: Fri, 25 Mar 2016 10:37:34 +0100 > This patch removes two BUG_ON() used to notify about RX queue corruptions > on macb (not gem) hardware without actually handling the error. > > The new code skips corrupted frames but still processes faultless frames. > Then it resets the RX queue before restarting the reception from a clean > state. > > This patch is a rework of an older patch proposed by Neil Armstrong: > http://patchwork.ozlabs.org/patch/371525/ > > Signed-off-by: Cyrille Pitchen > Acked-by: Neil Armstrong > Acked-by: Nicolas Ferre Applied, thank you.