Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754053AbcCYQ6t (ORCPT ); Fri, 25 Mar 2016 12:58:49 -0400 Received: from mail-lb0-f171.google.com ([209.85.217.171]:32945 "EHLO mail-lb0-f171.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753903AbcCYQ6s (ORCPT ); Fri, 25 Mar 2016 12:58:48 -0400 From: Felipe Balbi To: Peter Griffin , linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, mathias.nyman@intel.com, gregkh@linuxfoundation.org Cc: peter.griffin@linaro.org, lee.jones@linaro.org, linux-usb@vger.kernel.org, maxime.coquelin@st.com, patrice.chotard@st.com, stable@vger.kernel.org, gregory.clement@free-electrons.com, yoshihiro.shimoda.uh@renesas.com Subject: Re: [PATCH] usb: host: xhci-plat: Make enum xhci_plat_type start at a non zero value In-Reply-To: <1458917188-28452-1-git-send-email-peter.griffin@linaro.org> References: <1458917188-28452-1-git-send-email-peter.griffin@linaro.org> User-Agent: Notmuch/0.21 (http://notmuchmail.org) Emacs/25.0.91.3 (x86_64-pc-linux-gnu) Date: Fri, 25 Mar 2016 18:58:38 +0200 Message-ID: <87mvpm8pfl.fsf@ti.com> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha256; protocol="application/pgp-signature" Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2413 Lines: 68 --=-=-= Content-Type: text/plain Content-Transfer-Encoding: quoted-printable Hi, Peter Griffin writes: > Otherwise generic-xhci and xhci-platform which have no data get wrongly > detected as XHCI_PLAT_TYPE_MARVELL_ARMADA by xhci_plat_type_is(). > > This fixes a regression in v4.5 for STiH407 family SoC's which use the > synopsis dwc3 IP, whereby the disable_clk error path gets taken due to > wrongly being detected as XHCI_PLAT_TYPE_MARVELL_ARMADA and the hcd never > gets added. > > I suspect this will also fix other dwc3 DT platforms such as Exynos, > although I've only tested on STih410 SoC. > > Fixes: 4efb2f694114 ("usb: host: xhci-plat: add struct xhci_plat_priv") > Cc: stable@vger.kernel.org > Cc: gregory.clement@free-electrons.com > Cc: yoshihiro.shimoda.uh@renesas.com > Signed-off-by: Peter Griffin > --- > drivers/usb/host/xhci-plat.h | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/usb/host/xhci-plat.h b/drivers/usb/host/xhci-plat.h > index 5a2e2e3..529c3c4 100644 > --- a/drivers/usb/host/xhci-plat.h > +++ b/drivers/usb/host/xhci-plat.h > @@ -14,7 +14,7 @@ > #include "xhci.h" /* for hcd_to_xhci() */ >=20=20 > enum xhci_plat_type { > - XHCI_PLAT_TYPE_MARVELL_ARMADA, > + XHCI_PLAT_TYPE_MARVELL_ARMADA =3D 1, > XHCI_PLAT_TYPE_RENESAS_RCAR_GEN2, > XHCI_PLAT_TYPE_RENESAS_RCAR_GEN3, aren't these platforms using device tree ? Why aren't these just different compatible strings ? =2D-=20 balbi --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQIcBAEBCAAGBQJW9W4/AAoJEIaOsuA1yqREsDwQALMOQyLphGbenC9opWT1sdUd ZZCqCGXP8MgIKVTRKeIbih1Qhst+xP9E8P4IMAF0+sI4nk4PobXzqayirdeDh1K/ yN19Efmawn8brR/sran8pjojXhqA6B/KUZNI/L7i2yTwxlsCVUjgPduSuWR4lwdC TZ48HWIoxWqVdQjvx3eNbTFCc4cQCSGoKiBJGePSBF7n0W5mtsHSymaZkr54H+lC D+phgx34kRxhHXtD9aQ0ZsS9JjOfL6KoaILr3pjSTdset9BtslW5I5aInUnyWjVd DyohpR227srJidD/MxJSBHOWDCFhOJvvrw9G1upptl3KxOsMhILUmSit3p+c51M0 ujl4FQ3lexw+rT7cqOZh0+TJ9aA8kdY57lHgVNdmZHh6gqNdL6l8bUs0Bk/IjD0V 9cxC0nABogxynnUmtOK6LHFcMElPZF7TeGyaY4xi+YT4VLeZsF89aad4gOu19Q3T em85zZSl1/JWgZx6+4LqezXghrpHO5I6bSOwOLvdbYVdNL8oNapzNtd9/lLROJyT Up26S/pmWAMGbtyNOmreldWsUZ1kqsAYSrIW5Z+IGPXXvcGBL1DLmnegzzbnyCTG +OGwtKrIO67DIAOG/FwaK9EuZuZUi+2rx3q8lDlZwCrqNg6AWbscWC3sayZvoP5Q UOAQ+ahz0RiUJFjJ40L6 =isi+ -----END PGP SIGNATURE----- --=-=-=--