Subject: Re: [PATCH] Revert "regulator: core: Add support for active-discharge
 configuration"
To: Mark Brown <broonie@kernel.org>
References: <1458849121-11242-1-git-send-email-vladimir_zapolskiy@mentor.com>
 <20160325111050.GB2566@sirena.org.uk> <56F550B0.7050602@mentor.com>
 <20160325154507.GG2566@sirena.org.uk>
CC: Liam Girdwood <lgirdwood@gmail.com>,
        Laxman Dewangan <ldewangan@nvidia.com>, <linux-kernel@vger.kernel.org>,
        Russell King <linux@arm.linux.org.uk>
From: Vladimir Zapolskiy <vladimir_zapolskiy@mentor.com>
Message-ID: <56F5700D.2000105@mentor.com>
Date: Fri, 25 Mar 2016 19:06:21 +0200
User-Agent: Mozilla/5.0 (X11; Linux i686; rv:38.0) Gecko/20100101
 Icedove/38.1.0
MIME-Version: 1.0
In-Reply-To: <20160325154507.GG2566@sirena.org.uk>
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1423
Lines: 39

Mark,

On 25.03.2016 17:45, Mark Brown wrote:
> On Fri, Mar 25, 2016 at 04:52:32PM +0200, Vladimir Zapolskiy wrote:
>> On 25.03.2016 13:10, Mark Brown wrote:
> 
>>> Please submit patches using subject lines reflecting the style for the
>>> subsystem.  This makes it easier for people to identify relevant
>>> patches.
> 
>> Okay, submitting of reverted patches is different I believe:
> 
>> http://www.spinics.net/lists/arm-kernel/msg75667.html
> 
> Nope, they're patches like other patches.  A big part of what the
> subject line does is help people work out what they need to look at,
> something that doesn't pattern match doesn't fulfil that need.
> 

regarding pattern matching just remove ^ from the regexp and people
be aware of this "regulator: core" change.

I understand that the reverted commit is a maintainer's fault and by
renaming the subject you may hide it, so talking about people needs
please let them know that the change _reverts_ another commit.

I can not add Fixes: tag, because the change does not fix a commit, and
there is no Reverts: tag due to its obvious redundancy.

Please look at 1 hour old 1701f680407c ("Revert "ppdev: use new parport
device model" ") --- that's IMHO the proper way to create and apply
reverts.

And I disagree with the modified subject and commit message done by you
and without a notice mentioning this your change in the commit message.

--
With best wishes,
Vladimir