Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754173AbcCYRHY (ORCPT ); Fri, 25 Mar 2016 13:07:24 -0400 Received: from down.free-electrons.com ([37.187.137.238]:52672 "EHLO mail.free-electrons.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1753853AbcCYRHW (ORCPT ); Fri, 25 Mar 2016 13:07:22 -0400 From: Gregory CLEMENT To: Felipe Balbi Cc: Peter Griffin , linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, mathias.nyman@intel.com, gregkh@linuxfoundation.org, lee.jones@linaro.org, linux-usb@vger.kernel.org, maxime.coquelin@st.com, patrice.chotard@st.com, stable@vger.kernel.org, yoshihiro.shimoda.uh@renesas.com Subject: Re: [PATCH] usb: host: xhci-plat: Make enum xhci_plat_type start at a non zero value References: <1458917188-28452-1-git-send-email-peter.griffin@linaro.org> <87mvpm8pfl.fsf@ti.com> Date: Fri, 25 Mar 2016 18:07:09 +0100 In-Reply-To: <87mvpm8pfl.fsf@ti.com> (Felipe Balbi's message of "Fri, 25 Mar 2016 18:58:38 +0200") Message-ID: <87mvpmlc5e.fsf@free-electrons.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.5 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1977 Lines: 62 Hi Felipe, On ven., mars 25 2016, Felipe Balbi wrote: > Hi, > > Peter Griffin writes: >> Otherwise generic-xhci and xhci-platform which have no data get wrongly >> detected as XHCI_PLAT_TYPE_MARVELL_ARMADA by xhci_plat_type_is(). >> >> This fixes a regression in v4.5 for STiH407 family SoC's which use the >> synopsis dwc3 IP, whereby the disable_clk error path gets taken due to >> wrongly being detected as XHCI_PLAT_TYPE_MARVELL_ARMADA and the hcd never >> gets added. >> >> I suspect this will also fix other dwc3 DT platforms such as Exynos, >> although I've only tested on STih410 SoC. >> >> Fixes: 4efb2f694114 ("usb: host: xhci-plat: add struct xhci_plat_priv") >> Cc: stable@vger.kernel.org >> Cc: gregory.clement@free-electrons.com >> Cc: yoshihiro.shimoda.uh@renesas.com >> Signed-off-by: Peter Griffin >> --- >> drivers/usb/host/xhci-plat.h | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/drivers/usb/host/xhci-plat.h b/drivers/usb/host/xhci-plat.h >> index 5a2e2e3..529c3c4 100644 >> --- a/drivers/usb/host/xhci-plat.h >> +++ b/drivers/usb/host/xhci-plat.h >> @@ -14,7 +14,7 @@ >> #include "xhci.h" /* for hcd_to_xhci() */ >> >> enum xhci_plat_type { >> - XHCI_PLAT_TYPE_MARVELL_ARMADA, >> + XHCI_PLAT_TYPE_MARVELL_ARMADA = 1, >> XHCI_PLAT_TYPE_RENESAS_RCAR_GEN2, >> XHCI_PLAT_TYPE_RENESAS_RCAR_GEN3, > > aren't these platforms using device tree ? Why aren't these just > different compatible strings ? According to 4efb2f69411456d35051e9047c15157c9a5ba217 "usb: host: xhci-plat: add struct xhci_plat_priv" : This patch adds struct xhci_plat_priv to simplify the code to match platform specific variables. For now, this patch adds a member "type" in the structure Gregory > > -- > balbi -- Gregory Clement, Free Electrons Kernel, drivers, real-time and embedded Linux development, consulting, training and support. http://free-electrons.com