Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754021AbcCYSTo (ORCPT ); Fri, 25 Mar 2016 14:19:44 -0400 Received: from mezzanine.sirena.org.uk ([106.187.55.193]:39660 "EHLO mezzanine.sirena.org.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753254AbcCYSTn (ORCPT ); Fri, 25 Mar 2016 14:19:43 -0400 Date: Fri, 25 Mar 2016 18:19:29 +0000 From: Mark Brown To: Vladimir Zapolskiy Cc: Liam Girdwood , Laxman Dewangan , linux-kernel@vger.kernel.org, Russell King Message-ID: <20160325181929.GD5028@sirena.org.uk> References: <1458849121-11242-1-git-send-email-vladimir_zapolskiy@mentor.com> <20160325111050.GB2566@sirena.org.uk> <56F550B0.7050602@mentor.com> <20160325154507.GG2566@sirena.org.uk> <56F5700D.2000105@mentor.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="YToU2i3Vx8H2dn7O" Content-Disposition: inline In-Reply-To: <56F5700D.2000105@mentor.com> X-Cookie: Are you sure the back door is locked? User-Agent: Mutt/1.5.24 (2015-08-30) X-SA-Exim-Connect-IP: 2a01:348:6:8808:fab::3 X-SA-Exim-Mail-From: broonie@sirena.org.uk Subject: Re: [PATCH] Revert "regulator: core: Add support for active-discharge configuration" X-SA-Exim-Version: 4.2.1 (built Mon, 26 Dec 2011 16:24:06 +0000) X-SA-Exim-Scanned: Yes (on mezzanine.sirena.org.uk) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1865 Lines: 49 --YToU2i3Vx8H2dn7O Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Fri, Mar 25, 2016 at 07:06:21PM +0200, Vladimir Zapolskiy wrote: > On 25.03.2016 17:45, Mark Brown wrote: > > Nope, they're patches like other patches. A big part of what the > > subject line does is help people work out what they need to look at, > > something that doesn't pattern match doesn't fulfil that need. > regarding pattern matching just remove ^ from the regexp and people > be aware of this "regulator: core" change. The pattern matching in this case is typically being done by human beings. > Please look at 1 hour old 1701f680407c ("Revert "ppdev: use new parport > device model" ") --- that's IMHO the proper way to create and apply > reverts. The fact that a change happens to have been generated with a revert has no technical impact, you're not communicating with machines here but rather with people. Yes, some people don't mind especially if they're just directly publishing the commit (where it matters much less) but that doesn't override all other considerations. > And I disagree with the modified subject and commit message done by you > and without a notice mentioning this your change in the commit message. I already published it so it's a bit late now. --YToU2i3Vx8H2dn7O Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQEcBAEBCAAGBQJW9YEwAAoJECTWi3JdVIfQUgQH/iC75GscjHB0cuENc7NAYhtm ih2CUM7Lx9IdAUOa3XjVTvynGJ9Vk8SvnJiuJsMas0J9CaERawAWV12xhceUT/JW +nFPulU1SE/WALza0uE3+E8ZEPKpTK80p7NRNXQGvR0YM10D1WzkOi7t+6h7bvqS MvnvD12oIG3SNgr7wLH3NEnz6D4s037Pnf+v+1odKNGkdw36+h3mjhcNpyvxIVbx N7/PYOoe2NmTR1owcQwEFTBuNJhKwg0uNIIB5FEO2njYvfI4urSCgEDOfn9sMcPY AvqL2ItfyUxd7Yfw7GGbeaz65PH3ZSiz8+ZaI1oxMaaud23abSANARXD1FsZiQ4= =A/6I -----END PGP SIGNATURE----- --YToU2i3Vx8H2dn7O--