Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754339AbcCYVXF (ORCPT ); Fri, 25 Mar 2016 17:23:05 -0400 Received: from mail-pf0-f174.google.com ([209.85.192.174]:33285 "EHLO mail-pf0-f174.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753968AbcCYVXD (ORCPT ); Fri, 25 Mar 2016 17:23:03 -0400 Date: Fri, 25 Mar 2016 14:22:59 -0700 From: Bjorn Andersson To: Matthew McClintock , linus.walleij@linaro.org Cc: andy.gross@linaro.org, linux-arm-msm@vger.kernel.org, qca-upstream.external@qca.qualcomm.com, Rob Herring , Varadarajan Narayanan , Mathieu Olivari , "open list:PIN CONTROL SUBSYSTEM" , open list Subject: Re: [PATCH 02/17] pinctrl: qcom: ipq4019: fix the function enum for gpio mode Message-ID: <20160325212259.GB8929@tuxbot> References: <1458770712-10880-1-git-send-email-mmcclint@codeaurora.org> <1458770712-10880-3-git-send-email-mmcclint@codeaurora.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1458770712-10880-3-git-send-email-mmcclint@codeaurora.org> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1229 Lines: 38 On Wed 23 Mar 15:04 PDT 2016, Matthew McClintock wrote: > Without this, we would fail to set the mode to gpio if trying to > configure for that mode > > CC: linus.walleij@linaro.org Linus is the maintainer of the pinctrl subsystem, as such you should have him as recipient of these patches - so that he doesn't miss them while being only Cc. Acked-by: bjorn.andersson@linaro.org Regards, Bjorn > Signed-off-by: Matthew McClintock > --- > drivers/pinctrl/qcom/pinctrl-ipq4019.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/pinctrl/qcom/pinctrl-ipq4019.c b/drivers/pinctrl/qcom/pinctrl-ipq4019.c > index cb5f0a8..cb9f16a 100644 > --- a/drivers/pinctrl/qcom/pinctrl-ipq4019.c > +++ b/drivers/pinctrl/qcom/pinctrl-ipq4019.c > @@ -237,7 +237,7 @@ DECLARE_QCA_GPIO_PINS(99); > .pins = gpio##id##_pins, \ > .npins = (unsigned)ARRAY_SIZE(gpio##id##_pins), \ > .funcs = (int[]){ \ > - qca_mux_NA, /* gpio mode */ \ > + qca_mux_gpio, /* gpio mode */ \ > qca_mux_##f1, \ > qca_mux_##f2, \ > qca_mux_##f3, \ > -- > The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum, > a Linux Foundation Collaborative Project >