Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1752856AbcCZAjo (ORCPT <rfc822;w@1wt.eu>);
	Fri, 25 Mar 2016 20:39:44 -0400
Received: from zeniv.linux.org.uk ([195.92.253.2]:39519 "EHLO
	ZenIV.linux.org.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1752041AbcCZAjm (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Fri, 25 Mar 2016 20:39:42 -0400
Date: Sat, 26 Mar 2016 00:39:36 +0000
From: Al Viro <viro@ZenIV.linux.org.uk>
To: Zhang Zhuoyu <zhangzhuoyu@cmss.chinamobile.com>
Cc: "'Yan, Zheng'" <zyan@redhat.com>,
        "'Ceph Development'" <ceph-devel@vger.kernel.org>,
        "'Sage Weil'" <sage@redhat.com>, idryomov@gmail.com,
        linux-kernel@vger.kernel.org
Subject: Re: [PATCH]  fs/ceph: make logical calculation functions return bool
Message-ID: <20160326003936.GL17997@ZenIV.linux.org.uk>
References: <1458886795-10694-1-git-send-email-zhangzhuoyu@cmss.chinamobile.com>
 <7341F3B8-5F38-4D4C-A373-8DDD6472FC23@redhat.com>
 <000601d18672$4da04d80$e8e0e880$@cmss.chinamobile.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <000601d18672$4da04d80$e8e0e880$@cmss.chinamobile.com>
User-Agent: Mutt/1.5.21 (2010-09-15)
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
Content-Length: 409
Lines: 12

On Fri, Mar 25, 2016 at 04:42:45PM +0800, Zhang Zhuoyu wrote:
> > This one is for ilookup5.  ilookup5() wants function pointer "int (*test)(struct
> > inode *, void *)”.  The rest change looks good.
> > 
> > Regards
> > Yan, Zheng
> > 
> 
> Yes, you are right, I will send another version.

... as long as that another version does not try to switch the callback type
of ilookup5/iget5_locked/etc argument.