Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753455AbcCZCjj (ORCPT ); Fri, 25 Mar 2016 22:39:39 -0400 Received: from conssluserg001.nifty.com ([202.248.44.39]:63808 "EHLO conssluserg001-v.nifty.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1752074AbcCZCjh (ORCPT ); Fri, 25 Mar 2016 22:39:37 -0400 X-Nifty-SrcIP: [209.85.220.180] MIME-Version: 1.0 In-Reply-To: <20160324010749.f7e547e1df12b4944c5fa490@gmail.com> References: <20160307000208.1bec3e7dc874489d1b4fcbb4@gmail.com> <20160307000427.c82f18670568e1e656fc9532@gmail.com> <20160324010749.f7e547e1df12b4944c5fa490@gmail.com> Date: Sat, 26 Mar 2016 11:39:32 +0900 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH v5 2/5] GCC plugin infrastructure From: Masahiro Yamada To: Emese Revfy Cc: Linux Kbuild mailing list , pageexec@freemail.hu, spender@grsecurity.net, kernel-hardening@lists.openwall.com, Michal Marek , Kees Cook , Rasmus Villemoes , fengguang.wu@intel.com, Dmitry Vyukov , Linux Kernel Mailing List Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2103 Lines: 79 Hi Emese, 2016-03-24 9:07 GMT+09:00 Emese Revfy : > On Fri, 11 Mar 2016 15:25:19 +0900 > Masahiro Yamada wrote: > >> You sprinkle "gcc-plugins" target in the top Makefile, which I do not like. >> >> Can you descend into scripts/gcc-plugins from scripts/Makefile? >> >> >> subdir-$(CONFIG_MODVERSIONS) += genksyms >> subdir-y += mod >> subdir-$(CONFIG_SECURITY_SELINUX) += selinux >> subdir-$(CONFIG_DTC) += dtc >> subdir-$(CONFIG_GDB_SCRIPTS) += gdb >> +subdir-$(CONFIG_GCC_PLUGINS) += gcc-plugins >> >> >> This is how other host tools do, I think. > > Hi, > > I tried to remove the gcc-plugins target but sadly in this case the plugins aren't complied. > I don't know if I understand how it should work. I pushed a commit: > https://github.com/ephox-gcc-plugins/gcc-plugins_linux-next/commit/0b005b886bde6c4b9134d01f830d88d464911a65 > Could you please help me with what I did wrong? > Sorry, I missed this problem. GCC-plugins must be compiled before descending into ./Kbuild. Please apply the following on top of commit 0b005b88 and check if it works. diff --git a/Makefile b/Makefile index 1c7a379..bd643d3 100644 --- a/Makefile +++ b/Makefile @@ -1009,6 +1009,9 @@ archprepare: archheaders archscripts prepare1 scripts_basic prepare0: KBUILD_CFLAGS += $(GCC_PLUGINS_CFLAGS) prepare0: KBUILD_AFLAGS += $(GCC_PLUGINS_AFLAGS) prepare0: archprepare FORCE +ifdef CONFIG_GCC_PLUGINS + $(Q)$(MAKE) $(build)=scripts/gcc-plugins +endif $(Q)$(MAKE) $(build)=. # All the preparing.. diff --git a/scripts/Makefile b/scripts/Makefile index 0ba652c..1d80897 100644 --- a/scripts/Makefile +++ b/scripts/Makefile @@ -45,7 +45,6 @@ subdir-y += mod subdir-$(CONFIG_SECURITY_SELINUX) += selinux subdir-$(CONFIG_DTC) += dtc subdir-$(CONFIG_GDB_SCRIPTS) += gdb -subdir-$(CONFIG_GCC_PLUGINS) += gcc-plugins # Let clean descend into subdirs -subdir- += basic kconfig package +subdir- += basic kconfig package gcc-plugins -- Best Regards Masahiro Yamada