Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753351AbcCZR0Y (ORCPT ); Sat, 26 Mar 2016 13:26:24 -0400 Received: from relay1.mentorg.com ([192.94.38.131]:33777 "EHLO relay1.mentorg.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752594AbcCZR0W (ORCPT ); Sat, 26 Mar 2016 13:26:22 -0400 Subject: Re: ARC dw-mshc binding compat string To: Marek Vasut , "devicetree@vger.kernel.org" References: <56F66121.8050507@denx.de> CC: , Rob Herring , Alexey Brodkin From: Vladimir Zapolskiy Message-ID: <56F6C639.5000301@mentor.com> Date: Sat, 26 Mar 2016 19:26:17 +0200 User-Agent: Mozilla/5.0 (X11; Linux i686; rv:38.0) Gecko/20100101 Icedove/38.1.0 MIME-Version: 1.0 In-Reply-To: <56F66121.8050507@denx.de> Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit X-Originating-IP: [137.202.0.76] Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 986 Lines: 32 On 26.03.2016 12:14, Marek Vasut wrote: > Hi! > > I noticed that arch/arc/boot/dts/axs10x_mb.dtsi uses "altr," prefix in > the DT compatible string: > > mmc@0x15000 { > compatible = "altr,socfpga-dw-mshc"; > reg = < 0x15000 0x400 >; > num-slots = < 1 >; > fifo-depth = < 16 >; > card-detect-delay = < 200 >; > clocks = <&apbclk>, <&mmcclk>; > clock-names = "biu", "ciu"; > interrupts = < 7 >; > bus-width = < 4 >; > }; > > I don't think this is OK, since ARC is unrelated to Altera, which is > what the "altr," prefix stands for. I think the socfpga-dw-mshc shim > should be extended with another compatibility string, something like > "snps,arc-dw-mshc" and the axs10x_mb.dtsi should be adjusted > accordingly. What do you think ? > There is "snps,dw-mshc" described in Documentation/devicetree/bindings/mmc/synopsys-dw-mshc.txt and supported by dw_mmc host controller driver. -- With best wishes, Vladimir