Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753378AbcCZRqe (ORCPT ); Sat, 26 Mar 2016 13:46:34 -0400 Received: from us01smtprelay-2.synopsys.com ([198.182.60.111]:49648 "EHLO smtprelay.synopsys.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752594AbcCZRqc convert rfc822-to-8bit (ORCPT ); Sat, 26 Mar 2016 13:46:32 -0400 From: Alexey Brodkin To: Marek Vasut , "vladimir_zapolskiy@mentor.com" CC: Rob Herring , linux-kernel , devicetree Subject: Re: ARC dw-mshc binding compat string Thread-Topic: ARC dw-mshc binding compat string Thread-Index: AQHRh3XR+8AZfXSPZkS4sFe4xA8FkZ9r6YaAgAABDYCAABVYKw== Date: Sat, 26 Mar 2016 17:46:26 +0000 Message-ID: <6d6cf7b0-5bfd-40f4-9547-ae7ef48eed4a@email.android.com> References: <56F66121.8050507@denx.de> <56F6C639.5000301@mentor.com>,<56F6C71B.6070002@denx.de> In-Reply-To: <56F6C71B.6070002@denx.de> Accept-Language: en-US, ru-RU Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: Content-Type: text/plain; charset="koi8-r" Content-Transfer-Encoding: 8BIT MIME-Version: 1.0 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1318 Lines: 45 Hi Marek, Vladimir, 26 ????? 2016 ?. 20:30 ???????????? Marek Vasut ???????: > > On 03/26/2016 06:26 PM, Vlad On 03/26/2016 06:26 PM, Vladimir Zapolskiy wrote: > On 26.03.2016 12:14, Marek Vasut wrote: >> Hi! >> >> I noticed that arch/arc/boot/dts/axs10x_mb.dtsi uses "altr," prefix in >> the DT compatible string: >> >> mmc@0x15000 { >> compatible = "altr,socfpga-dw-mshc"; >> reg = < 0x15000 0x400 >; >> num-slots = < 1 >; >> fifo-depth = < 16 >; >> card-detect-delay = < 200 >; >> clocks = <&apbclk>, <&mmcclk>; >> clock-names = "biu", "ciu"; >> interrupts = < 7 >; >> bus-width = < 4 >; >> }; >> >> I don't think this is OK, since ARC is unrelated to Altera, which is >> what the "altr," prefix stands for. I think the socfpga-dw-mshc shim >> should be extended with another compatibility string, something like >> "snps,arc-dw-mshc" and the axs10x_mb.dtsi should be adjusted >> accordingly. What do you think ? >> > > There is "snps,dw-mshc" described in > Documentation/devicetree/bindings/mmc/synopsys-dw-mshc.txt and supported by > dw_mmc host controller driver. Thanks, that's even better. btw what do you think of using altr, prefix on non-altera system, that doesn't seem ok, right ? -- Best regards, Marek Vasut