Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754467AbcCZWIb (ORCPT ); Sat, 26 Mar 2016 18:08:31 -0400 Received: from mout01.posteo.de ([185.67.36.65]:56900 "EHLO mout01.posteo.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750963AbcCZWI2 (ORCPT ); Sat, 26 Mar 2016 18:08:28 -0400 In-Reply-To: <20160324152815.3489c6d54270f278e5dc7db4@linux-foundation.org> References: <1458788612-4367-1-git-send-email-zhaoxiu.zeng@gmail.com> <56F3A77D.6060802@redhat.com> <20160324152815.3489c6d54270f278e5dc7db4@linux-foundation.org> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain; charset=UTF-8 Subject: Re: [PATCH 01/31] bitops: add parity functions From: Martin Kepplinger Date: Sat, 26 Mar 2016 23:08:20 +0100 To: Andrew Morton , Denys Vlasenko CC: Zhaoxiu Zeng , Arnd Bergmann , Sasha Levin , Ingo Molnar , Yury Norov , linux-kernel@vger.kernel.org, linux-arch@vger.kernel.org Message-ID: <5C852AF0-E161-4219-B8C8-7CE3140B73C3@posteo.de> Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 561 Lines: 21 We do. Am 24. März 2016 23:28:15 MEZ, schrieb Andrew Morton : >On Thu, 24 Mar 2016 09:38:21 +0100 Denys Vlasenko >wrote: > >> On 03/24/2016 04:03 AM, Zhaoxiu Zeng wrote: >> > +/* >> > + * Type invariant interface to the compile time constant parity >functions. >> > + */ >> > +#define PARITY(w) PARITY64((u64)w) >> >> Can result in incorrect expansion of w. Should be PARITY64((u64)(w)) > >And we seem to be missing the other 30 patches. -- Martin Kepplinger http://martinkepplinger.com sent from mobile