Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752318AbcC0FuW (ORCPT ); Sun, 27 Mar 2016 01:50:22 -0400 Received: from mail-pa0-f44.google.com ([209.85.220.44]:34815 "EHLO mail-pa0-f44.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751072AbcC0FuQ (ORCPT ); Sun, 27 Mar 2016 01:50:16 -0400 Date: Sat, 26 Mar 2016 22:50:12 -0700 From: Bjorn Andersson To: Srinivas Kandagatla Cc: Andy Gross , linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-soc@vger.kernel.org Subject: Re: [PATCH 10/12] ARM: dts: dragonboard-600c: Add on board leds support Message-ID: <20160327055012.GD8929@tuxbot> References: <1458762366-9233-1-git-send-email-srinivas.kandagatla@linaro.org> <1458762484-9768-1-git-send-email-srinivas.kandagatla@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1458762484-9768-1-git-send-email-srinivas.kandagatla@linaro.org> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1915 Lines: 72 On Wed 23 Mar 12:48 PDT 2016, Srinivas Kandagatla wrote: > This patch adds support to 4 user leds, wlan and bt led on board. > > Signed-off-by: Srinivas Kandagatla I'm not fond of the overly complicated names; and I think it should at least be shortened to "db600c:...". Tested this on my DB600c, seems to work, except the WiFi/BT triggers, see comments below. > + leds { > + pinctrl-names = "default"; > + pinctrl-0 = <&user_leds>, <&mpp_leds>; > + > + compatible = "gpio-leds"; > + > + led@1 { > + label = "dragonboard-600c:green:user1"; > + gpios = <&tlmm_pinmux 3 GPIO_ACTIVE_HIGH>; > + linux,default-trigger = "heartbeat"; > + default-state = "off"; > + }; > + > + led@2 { > + label = "dragonboard-600c:green:user2"; > + gpios = <&tlmm_pinmux 7 GPIO_ACTIVE_HIGH>; > + linux,default-trigger = "mmc0"; > + default-state = "off"; > + }; > + > + led@3 { > + label = "dragonboard-600c:green:user3"; > + gpios = <&tlmm_pinmux 10 GPIO_ACTIVE_HIGH>; > + linux,default-trigger = "mmc1"; > + default-state = "off"; > + }; > + > + led@4 { > + label = "apq8016-sbc:green:user4"; > + gpios = <&tlmm_pinmux 11 GPIO_ACTIVE_HIGH>; > + linux,default-trigger = "none"; > + default-state = "off"; > + }; > + > + led@5 { > + label = "dragonboard-600c:yellow:wlan"; > + gpios = <&pm8921_mpps 7 GPIO_ACTIVE_HIGH>; > + linux,default-trigger = "wlan"; This should either be "phy0rx", "phy0tx", "phy0assoc" or "phy0radio". TX does not seem to work, so this should be debugged; "assoc" is probably the one that makes most sense. > + default-state = "off"; > + }; > + > + led@6 { > + label = "dragonboard-600c:blue:bt"; > + gpios = <&pm8921_mpps 8 GPIO_ACTIVE_HIGH>; > + linux,default-trigger = "bt"; This should be "hci0-power". > + default-state = "off"; > + }; > + }; > + Regards, Bjorn