Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754075AbcC0H2L (ORCPT ); Sun, 27 Mar 2016 03:28:11 -0400 Received: from mail-pf0-f195.google.com ([209.85.192.195]:36366 "EHLO mail-pf0-f195.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752974AbcC0H17 (ORCPT ); Sun, 27 Mar 2016 03:27:59 -0400 Subject: [PATCH 22/31] mtd: use parity functions in inftlcore.c To: David Woodhouse , Brian Norris References: <1458788612-4367-1-git-send-email-zhaoxiu.zeng@gmail.com> Cc: linux-kernel@vger.kernel.org, linux-mtd@lists.infradead.org From: "zhaoxiu.zeng" Message-ID: <56F78B63.3050805@gmail.com> Date: Sun, 27 Mar 2016 15:27:31 +0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:38.0) Gecko/20100101 Thunderbird/38.7.1 MIME-Version: 1.0 In-Reply-To: <1458788612-4367-1-git-send-email-zhaoxiu.zeng@gmail.com> Content-Type: text/plain; charset=gbk Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1407 Lines: 44 From: Zeng Zhaoxiu Signed-off-by: Zeng Zhaoxiu --- drivers/mtd/inftlcore.c | 17 ++++------------- 1 file changed, 4 insertions(+), 13 deletions(-) diff --git a/drivers/mtd/inftlcore.c b/drivers/mtd/inftlcore.c index b66b541..29567bb 100644 --- a/drivers/mtd/inftlcore.c +++ b/drivers/mtd/inftlcore.c @@ -457,15 +457,6 @@ static u16 INFTL_makefreeblock(struct INFTLrecord *inftl, unsigned pendingblock) return INFTL_foldchain(inftl, LongestChain, pendingblock); } -static int nrbits(unsigned int val, int bitcount) -{ - int i, total = 0; - - for (i = 0; (i < bitcount); i++) - total += (((0x1 << i) & val) ? 1 : 0); - return total; -} - /* * INFTL_findwriteunit: Return the unit number into which we can write * for this block. Make it available if it isn't already. @@ -593,10 +584,10 @@ hitused: if (prev_block < inftl->nb_blocks) prev_block -= inftl->firstEUN; - parity = (nrbits(thisVUC, 16) & 0x1) ? 0x1 : 0; - parity |= (nrbits(prev_block, 16) & 0x1) ? 0x2 : 0; - parity |= (nrbits(anac, 8) & 0x1) ? 0x4 : 0; - parity |= (nrbits(nacs, 8) & 0x1) ? 0x8 : 0; + parity = parity16(thisVUC); + parity |= parity16(prev_block) << 1; + parity |= parity8(anac) << 2; + parity |= parity8(nacs) << 3; oob.u.a.virtualUnitNo = cpu_to_le16(thisVUC); oob.u.a.prevUnitNo = cpu_to_le16(prev_block); -- 2.5.5