Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754518AbcC0Huh (ORCPT ); Sun, 27 Mar 2016 03:50:37 -0400 Received: from mail-pf0-f195.google.com ([209.85.192.195]:35064 "EHLO mail-pf0-f195.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753207AbcC0Hu2 (ORCPT ); Sun, 27 Mar 2016 03:50:28 -0400 Subject: [PATCH 31/31] ethernet: broadcom: use parity8 in tg3.c References: <1458788612-4367-1-git-send-email-zhaoxiu.zeng@gmail.com> Cc: linux-kernel@vger.kernel.org, netdev@vger.kernel.org To: Siva Reddy Kallam , Prashant Sreedharan , Michael Chan From: "zhaoxiu.zeng" Message-ID: <56F790A9.3000501@gmail.com> Date: Sun, 27 Mar 2016 15:50:01 +0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:38.0) Gecko/20100101 Thunderbird/38.7.1 MIME-Version: 1.0 In-Reply-To: <1458788612-4367-1-git-send-email-zhaoxiu.zeng@gmail.com> Content-Type: text/plain; charset=gbk Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 743 Lines: 26 From: Zeng Zhaoxiu Signed-off-by: Zeng Zhaoxiu --- drivers/net/ethernet/broadcom/tg3.c | 6 +----- 1 file changed, 1 insertion(+), 5 deletions(-) diff --git a/drivers/net/ethernet/broadcom/tg3.c b/drivers/net/ethernet/broadcom/tg3.c index 3010080..802a429 100644 --- a/drivers/net/ethernet/broadcom/tg3.c +++ b/drivers/net/ethernet/broadcom/tg3.c @@ -12939,11 +12939,7 @@ static int tg3_test_nvram(struct tg3 *tp) err = -EIO; for (i = 0; i < NVRAM_SELFBOOT_DATA_SIZE; i++) { - u8 hw8 = hweight8(data[i]); - - if ((hw8 & 0x1) && parity[i]) - goto out; - else if (!(hw8 & 0x1) && !parity[i]) + if (parity8(data[i]) == !!parity[i]) goto out; } err = 0; -- 2.5.5